Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix the issue of reading paimon table on OSS #34996

Merged
merged 2 commits into from
Nov 15, 2023
Merged

[BugFix] fix the issue of reading paimon table on OSS #34996

merged 2 commits into from
Nov 15, 2023

Conversation

miomiocat
Copy link
Contributor

@miomiocat miomiocat commented Nov 14, 2023 •
edited
Loading

  • Support reading paimon table on aliyun OSS
  • Simplify relevant code

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@miomiocat
[BugFix] fix the issue of reading paimon table on OSS
b2402d7 
Signed-off-by: miomiocat <284487410@qq.com>
@miomiocat
ut
562d36d 
Signed-off-by: miomiocat <284487410@qq.com>
@miomiocat miomiocat enabled auto-merge (squash) November 15, 2023 03:36
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 29 / 32 (90.62%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/paimon/PaimonConnector.java 15 18 83.33% [85, 86, 87]
🔵 com/starrocks/credential/aliyun/AliyunCloudCredential.java 3 3 100.00% []
🔵 com/starrocks/connector/paimon/PaimonMetadata.java 3 3 100.00% []
🔵 com/starrocks/catalog/PaimonTable.java 7 7 100.00% []
🔵 com/starrocks/credential/aliyun/AliyunCloudConfiguration.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 0 / 4 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/connector/hive_connector.cpp 0 1 00.00% [573]
🔵 src/runtime/descriptors.cpp 0 3 00.00% [325, 336, 337]

@miomiocat miomiocat merged commit e95749d into StarRocks:main Nov 15, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 15, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 15, 2023
@miomiocat @mergify
[BugFix] fix the issue of reading paimon table on OSS (#34996)
747ec1b 
Signed-off-by: miomiocat <284487410@qq.com>
(cherry picked from commit e95749d)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/PaimonTable.java
#	fe/fe-core/src/main/java/com/starrocks/connector/paimon/PaimonMetadata.java
#	fe/fe-core/src/test/java/com/starrocks/catalog/PaimonTableTest.java
@mergify mergify bot mentioned this pull request Nov 15, 2023
Closed
miomiocat added a commit to miomiocat/starrocks that referenced this pull request Nov 15, 2023
@miomiocat
[BugFix] fix the issue of reading paimon table on OSS (StarRocks#34996)
7cfae73 
Signed-off-by: miomiocat <284487410@qq.com>
(cherry picked from commit e95749d)
@miomiocat miomiocat mentioned this pull request Nov 15, 2023
Merged
22 tasks
miomiocat added a commit that referenced this pull request Nov 15, 2023
@miomiocat
[BugFix] fix the issue of reading paimon table on OSS (#34996)
861079c 
Signed-off-by: miomiocat <284487410@qq.com>
(cherry picked from commit e95749d)
@miomiocat miomiocat deleted the paimon_github branch November 20, 2023 06:40
@miomiocat miomiocat mentioned this pull request Nov 28, 2023
Closed
22 tasks
wxl24life pushed a commit to wxl24life/starrocks that referenced this pull request Feb 22, 2024
@caneGuy
[Backport][BugFix] fix the issue of reading paimon table on OSS (Star…
7e2fc27 
…Rocks#34996)

Signed-off-by: miomiocat <284487410@qq.com>
(cherry picked from commit e95749d)
@dirtysalt
Copy link
Contributor

@mergify backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 23, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 23, 2024
@miomiocat @mergify
[BugFix] fix the issue of reading paimon table on OSS (#34996)
273490b 
Signed-off-by: miomiocat <284487410@qq.com>
(cherry picked from commit e95749d)

# Conflicts:
#	be/src/connector/hive_connector.cpp
#	fe/fe-core/src/test/java/com/starrocks/catalog/PaimonTableTest.java
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/ConnectorPlanTestBase.java
@mergify mergify bot mentioned this pull request Feb 23, 2024
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Feb 23, 2024
@mergify @miomiocat @dirtysalt
[BugFix] fix the issue of reading paimon table on OSS (backport #34996)…
24aba6e 
… (#41516)

Signed-off-by: yanz <dirtysalt1987@gmail.com>
Co-authored-by: miomiocat <284487410@qq.com>
Co-authored-by: yanz <dirtysalt1987@gmail.com>
caneGuy pushed a commit to caneGuy/starrocks that referenced this pull request Mar 22, 2024
@miomiocat
[Backport][BugFix] fix the issue of reading paimon table on OSS (Star…
5e86501 
…Rocks#34996)

Signed-off-by: miomiocat <284487410@qq.com>
(cherry picked from commit e95749d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@dirtysalt dirtysalt dirtysalt approved these changes

@stephen-shelby stephen-shelby stephen-shelby approved these changes

Assignees

@miomiocat miomiocat

Labels
3.1-merged PROTO-REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miomiocat @dirtysalt @stephen-shelby