[BugFix] fix expensive Partition.equals

[murphyatwork]

Why I'm doing:

• The Partition.equals is too expensive to used as map key

What I'm doing:

• Avoid use Partition as Map key
• Add Partition.id to hashCode

Fixes #issue

What type of PR is this:

• BugFix
• Feature
• Enhancement
• Refactor
• UT
• Doc
• Tool

Does this PR entail a change in behavior?

• Yes, this PR will result in a change in behavior.
• No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

• Interface/UI changes: syntax, type conversion, expression evaluation, display information
• Parameter changes: default values, similar parameters but with different default values
• Policy changes: use new policy to replace old one, functionality automatically enabled
• Feature removed
• Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

• I have added test cases for my bug fix or my new feature
• This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

• I have checked the version labels which the pr will be auto-backported to the target branch
  • 3.2
  • 3.1
  • 3.0
  • 2.5

[starrocks-cr]

The most risky bug in this code is:
Incorrect usage of Partition and PartitionDesc pairs after changing from a Map to a List<Pair<Partition, PartitionDesc>>.

You can modify the code like this:

// Wherever partitionMap was used, replace it with partitionList using appropriate methods
// For example, you would access the entries with something like this:
for (Pair<Partition, PartitionDesc> entry : partitionList) {
    Partition partition = entry.first;
    PartitionDesc partitionDesc = entry.second;
    // Use partition and partitionDesc as needed
}

Make sure to review the entire code and replace all usages of the old partitionMap with the new partitionList, accessing the items through their .first and .second properties.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
7 Code Smells

0.0% Coverage
0.0% Duplication

The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

[github-actions]

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

[github-actions]

[FE Incremental Coverage Report]

✅ pass : 22 / 24 (91.67%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/catalog/Partition.java	2	4	50.00%	[580, 596]
🔵	com/starrocks/catalog/ListPartitionInfo.java	3	3	100.00%	[]
🔵	com/starrocks/catalog/RangePartitionInfo.java	4	4	100.00%	[]
🔵	com/starrocks/server/LocalMetastore.java	13	13	100.00%	[]

[github-actions]

@Mergifyio backport branch-3.2

[github-actions]

@Mergifyio backport branch-3.1

[mergify]

backport branch-3.2

✅ Backports have been created

• #34986 [BugFix] fix expensive Partition.equals (backport #34961) has been created for branch branch-3.2

[mergify]

backport branch-3.1

✅ Backports have been created

• #34987 [BugFix] fix expensive Partition.equals (backport #34961) has been created for branch branch-3.1 but encountered conflicts