Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix lake pk table compaction when compaction state cache not exist #34955

Merged
merged 1 commit into from
Nov 14, 2023
Merged

[BugFix] fix lake pk table compaction when compaction state cache not exist #34955

merged 1 commit into from
Nov 14, 2023

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Nov 14, 2023

Why I'm doing:
Because when BE restart, compaction state cache is not exist, and compaction_state.pk_cols will be empty. Then publish compaction will miss to update pk index.

What I'm doing:
Fix this issue,

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@luohaha
[BugFix] fix lake pk table compaction when state cache not exist
a52958b 
Signed-off-by: luohaha <18810541851@163.com>
@luohaha luohaha force-pushed the fix-lake-pk-compaction branch from 758346d to a52958b Compare November 14, 2023 07:49
@wyb wyb enabled auto-merge (squash) November 14, 2023 08:51
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@wyb wyb merged commit 6b3f0ab into StarRocks:main Nov 14, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 7 / 7 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/storage/lake/update_manager.cpp 7 7 100.00% []

mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@luohaha @mergify
[BugFix] fix lake pk table compaction when compaction state cache not…
499c96a 
… exist (#34955)

Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit 6b3f0ab)

# Conflicts:
#	be/src/storage/lake/update_manager.cpp
mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@luohaha @mergify
[BugFix] fix lake pk table compaction when compaction state cache not…
c7d29af 
… exist (#34955)

Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit 6b3f0ab)
This was referenced Nov 14, 2023
Merged
Closed
@luohaha luohaha mentioned this pull request Nov 14, 2023
Merged
22 tasks
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2023
@luohaha @wanpengfei-git
[BugFix] fix lake pk table compaction when compaction state cache not…
32d6f9c 
… exist (#34955)

Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit 6b3f0ab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@sduzh sduzh sduzh approved these changes

Assignees

@luohaha luohaha

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luohaha @wyb @sduzh @wanpengfei-git