Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix error message when substr/substring meets illegal interger #34921

Merged
merged 1 commit into from
Nov 14, 2023
Merged

[BugFix] Fix error message when substr/substring meets illegal interger #34921

merged 1 commit into from
Nov 14, 2023

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Nov 14, 2023 •
edited
Loading

Why I'm doing:

substring/substr only supports int type as argument, when it meets overflow long value, it throws exception below:

Unexpected exception: Number out of range[0]. type: INT

What I'm doing:

  • Fix error message when substr/substring meets illegal interger
  • Add more illegal tests

Fixes #3196

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@LiShuMing
Fix error message when substr/substring meets illegal interger
585dc13 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
@LiShuMing LiShuMing requested review from a team as code owners November 14, 2023 04:38
@github-actions github-actions bot added the 3.2 label Nov 14, 2023
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 6 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/analysis/IntLiteral.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@LiShuMing LiShuMing enabled auto-merge (squash) November 14, 2023 07:17
@LiShuMing LiShuMing merged commit 368c135 into StarRocks:main Nov 14, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 14, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@LiShuMing @mergify
[BugFix] Fix error message when substr/substring meets illegal interg…
15a7a50 
…er (#34921)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit 368c135)
@mergify mergify bot mentioned this pull request Nov 14, 2023
Merged
wanpengfei-git pushed a commit that referenced this pull request Nov 16, 2023
@LiShuMing @wanpengfei-git
[BugFix] Fix error message when substr/substring meets illegal interg…
de79fb7 
…er (#34921)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit 368c135)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imay imay imay approved these changes

@satanson satanson satanson approved these changes

@Seaven Seaven Seaven approved these changes

Assignees

@LiShuMing LiShuMing

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LiShuMing @imay @satanson @Seaven @wanpengfei-git