Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix show alter table optimize with filter #34897

Merged
merged 1 commit into from
Nov 15, 2023
Merged

[BugFix] Fix show alter table optimize with filter #34897

merged 1 commit into from
Nov 15, 2023

Conversation

meegoo
Copy link
Contributor

@meegoo meegoo commented Nov 14, 2023 •
edited
Loading

Why I'm doing:

support

show alter table optimize where tableName='duplicate_table_with_null_partition' order by CreateTime desc;

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@mergify mergify bot assigned meegoo Nov 14, 2023
@github-actions github-actions bot added the 3.2 label Nov 14, 2023
@meegoo
[BugFix] Fix show alter table optimize with filter
f0c9027 
Signed-off-by: meegoo <meegoo.sr@gmail.com>
@meegoo meegoo force-pushed the fix_show_alter_table_optimize_filter branch from a676f1d to f0c9027 Compare November 14, 2023 07:34
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@meegoo meegoo enabled auto-merge (squash) November 14, 2023 09:31
@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 3 / 3 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/ShowExecutor.java 3 3 100.00% []

@meegoo meegoo merged commit b5848a2 into StarRocks:main Nov 15, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 15, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 15, 2023
@meegoo @mergify
[BugFix] Fix show alter table optimize with filter (#34897)
c6306f8 
Signed-off-by: meegoo <meegoo.sr@gmail.com>
(cherry picked from commit b5848a2)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/qe/ShowExecutorTest.java
@mergify mergify bot mentioned this pull request Nov 15, 2023
Merged
meegoo added a commit that referenced this pull request Nov 15, 2023
@mergify @meegoo
[BugFix] Fix show alter table optimize with filter (backport #34897) (#…
73ac7fa 
…35019)

Co-authored-by: meegoo <meegoo.sr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imay imay imay approved these changes

@nshangyiming nshangyiming nshangyiming approved these changes

Assignees

@meegoo meegoo

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meegoo @imay @nshangyiming @wanpengfei-git