Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix optimize table fail when specify partition name #34896

Merged

Conversation

meegoo
Copy link
Contributor

@meegoo meegoo commented Nov 14, 2023

Why I'm doing this:
Fix optimize table failure when specifying partition name

alter table duplicate_table_with_null_partition PARTITIONS(p202006,p202007,p202008) DISTRIBUTED BY HASH(`k1`, `k2`, `k3`, `k4`, `k5`) BUCKETS 4 ;

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@meegoo meegoo requested a review from a team as a code owner November 14, 2023 00:20
@mergify mergify bot assigned meegoo Nov 14, 2023
@github-actions github-actions bot added the 3.2 label Nov 14, 2023
@meegoo meegoo enabled auto-merge (squash) November 14, 2023 00:47
@imay
Copy link
Contributor

imay commented Nov 14, 2023

Fix optimize table fail when specify partition name
alter table duplicate_table_with_null_partition DISTRIBUTED BY HASH(k1, k2, k3, k4, k5) BUCKETS 4 PARTITIONS(p202006,p202007,p202008);

My question is why the partition doesn't follow the table name as it is in select/insert into statements.

@meegoo meegoo disabled auto-merge November 14, 2023 01:59
@meegoo meegoo force-pushed the fix_optimize_table_fail_when_specify_partitions branch from 77fd4a5 to 502d447 Compare November 14, 2023 08:02
@meegoo meegoo requested a review from a team as a code owner November 14, 2023 08:02
@meegoo meegoo force-pushed the fix_optimize_table_fail_when_specify_partitions branch from 502d447 to 205f2c6 Compare November 14, 2023 08:33
Signed-off-by: meegoo <meegoo.sr@gmail.com>
@meegoo meegoo force-pushed the fix_optimize_table_fail_when_specify_partitions branch from 205f2c6 to 150c79c Compare November 14, 2023 09:23
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

0.0% 0.0% Coverage
6.7% 6.7% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 5 / 6 (83.33%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/analyzer/AlterTableClauseVisitor.java 0 1 00.00% [388]
🔵 com/starrocks/alter/OptimizeTask.java 1 1 100.00% []
🔵 com/starrocks/alter/OptimizeJobV2.java 4 4 100.00% []

@meegoo meegoo enabled auto-merge (squash) November 14, 2023 19:30
@meegoo
Copy link
Contributor Author

meegoo commented Nov 14, 2023

Fix optimize table fail when specify partition name
alter table duplicate_table_with_null_partition DISTRIBUTED BY HASH(k1, k2, k3, k4, k5) BUCKETS 4 PARTITIONS(p202006,p202007,p202008);

My question is why the partition doesn't follow the table name as it is in select/insert into statements.

change the order make partitions after table

@meegoo meegoo merged commit 04a0be7 into StarRocks:main Nov 14, 2023
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 14, 2023
Copy link
Contributor

mergify bot commented Nov 14, 2023

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 14, 2023
Signed-off-by: meegoo <meegoo.sr@gmail.com>
(cherry picked from commit 04a0be7)

# Conflicts:
#	test/sql/test_optimize_table/R/test_optimize_table
meegoo added a commit that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants