[BugFix] Fix partition resolve bug for materialized view #34880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
fe/fe-core/src/main/java/com/starrocks/sql/analyzer/SlotRefResolver.java
Show resolved
Hide resolved
LiShuMing
force-pushed
the
fix/main/mv_partition_bugfix
branch
from
d56a3cd to
9cdfb5f
Compare
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
LiShuMing
force-pushed
the
fix/main/mv_partition_bugfix
branch
from
9cdfb5f to
48539de
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
murphyatwork
approved these changes
Nov 14, 2023
ABingHuang
reviewed
Nov 14, 2023
| @@ -709,11 +710,11 @@ private void checkPartitionExpPatterns(CreateMaterializedViewStatement statement | |||
| MaterializedViewPartitionFunctionChecker.FN_NAME_TO_PATTERN.get(functionName); | |||
| if (checkPartitionFunction == null) { | |||
| throw new SemanticException("Materialized view partition function " + | |||
| functionName + " is not support", functionCallExpr.getPos()); | |||
| functionName + " is not support: " + expr.toSqlWithoutTbl(), functionCallExpr.getPos()); | |||
There was a problem hiding this comment.
Suggested change
| functionName + " is not support: " + expr.toSqlWithoutTbl(), functionCallExpr.getPos()); | |
| functionName + " is not supported: " + expr.toSqlWithoutTbl(), functionCallExpr.getPos()); |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 62 / 72 (86.11%) file detail
|
ABingHuang
approved these changes
Nov 14, 2023
Seaven
approved these changes
Nov 14, 2023
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.1 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 14, 2023
Signed-off-by: shuming.li <ming.moriarty@gmail.com> (cherry picked from commit b4c7c21) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AnalyzerUtils.java # fe/fe-core/src/main/java/com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java # fe/fe-core/src/test/java/com/starrocks/analysis/CreateMaterializedViewTest.java # fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvRefreshAndRewriteJDBCTest.java
mergify bot
pushed a commit
that referenced
this pull request
Nov 14, 2023
Signed-off-by: shuming.li <ming.moriarty@gmail.com> (cherry picked from commit b4c7c21) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AnalyzerUtils.java
This was referenced Nov 14, 2023
LiShuMing
added a commit
to LiShuMing/starrocks
that referenced
this pull request
Nov 16, 2023
…4880) Signed-off-by: shuming.li <ming.moriarty@gmail.com>
LiShuMing
added a commit
to LiShuMing/starrocks
that referenced
this pull request
Nov 16, 2023
…4880) Signed-off-by: shuming.li <ming.moriarty@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
After PR(#32077)， analyzer cannot resolve partition column from
select *.It throws
Resolve partition column failed.with nothing else.What I'm doing:
select *by addingvisitFieldReferenceinc;Resolve partition column failed.SlotRefResolverFactoryinto an indenpendant classSlotRefResolverFactoryFixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: