Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix query_excluding_mv_names and query_including_mv_names bugs #34873

Merged
merged 1 commit into from
Nov 14, 2023
Merged

[BugFix] fix query_excluding_mv_names and query_including_mv_names bugs #34873

merged 1 commit into from
Nov 14, 2023

Conversation

ABingHuang
Copy link
Contributor

@ABingHuang ABingHuang commented Nov 13, 2023 •
edited
Loading

Fix #34867
Why I'm doing:

  1. when query_excluding_mv_names is set and query_including_mv_names is not set, no related mv is considered for rewrite
  2. mv names with pre or post space is not applicable.

What I'm doing:

  1. when query_including_mv_names is not set, should consider all related mvs
  2. add trim for mv names for better usability

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@ABingHuang ABingHuang requested a review from a team as a code owner November 13, 2023 09:36
@ABingHuang ABingHuang force-pushed the issue/34867_fix_query_excluding_mv_names_session_variable branch from ab6a56b to b637e01 Compare November 13, 2023 09:37
@ABingHuang ABingHuang enabled auto-merge (squash) November 13, 2023 09:39
@ABingHuang
fix query_excluding_mv_names and query_including_mv_names bugs
5f0aec5 
1. when query_including_mv_names is not set, should consider all related mvs
2. add trim for mv names for better usability

Signed-off-by: ABingHuang <codekhuang@163.com>
@ABingHuang ABingHuang force-pushed the issue/34867_fix_query_excluding_mv_names_session_variable branch from b637e01 to 5f0aec5 Compare November 14, 2023 03:09
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 15 / 15 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/MvRewritePreprocessor.java 6 6 100.00% []
🔵 com/starrocks/sql/optimizer/dump/QueryDumpInfo.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/MvPlanContextBuilder.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/MaterializedViewOptimizer.java 7 7 100.00% []

@ABingHuang ABingHuang merged commit 536efe4 into StarRocks:main Nov 14, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 14, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Nov 14, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@github-actions github-actions bot removed the 3.0 label Nov 14, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@ABingHuang @mergify
[BugFix] fix query_excluding_mv_names and query_including_mv_names bu…
fc651d6 
…gs (#34873)

1. when query_including_mv_names is not set, should consider all related mvs
2. add trim for mv names for better usability

Signed-off-by: ABingHuang <codekhuang@163.com>
(cherry picked from commit 536efe4)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/MvPlanContextBuilder.java
mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@ABingHuang @mergify
[BugFix] fix query_excluding_mv_names and query_including_mv_names bu…
d5b3b3b 
…gs (#34873)

1. when query_including_mv_names is not set, should consider all related mvs
2. add trim for mv names for better usability

Signed-off-by: ABingHuang <codekhuang@163.com>
(cherry picked from commit 536efe4)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/MvPlanContextBuilder.java
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/MvRewritePreprocessor.java
This was referenced Nov 14, 2023
Closed
Closed
mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@ABingHuang @mergify
[BugFix] fix query_excluding_mv_names and query_including_mv_names bu…
c784a97 
…gs (#34873)

1. when query_including_mv_names is not set, should consider all related mvs
2. add trim for mv names for better usability

Signed-off-by: ABingHuang <codekhuang@163.com>
(cherry picked from commit 536efe4)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/MvPlanContextBuilder.java
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/MvRewritePreprocessor.java
#	fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvRewriteTest.java
@mergify mergify bot mentioned this pull request Nov 14, 2023
Closed
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Nov 16, 2023
@ABingHuang
[BugFix] fix query_excluding_mv_names and query_including_mv_names bu…
38ea02a 
…gs (StarRocks#34873)

1. when query_including_mv_names is not set, should consider all related mvs
2. add trim for mv names for better usability

Signed-off-by: ABingHuang <codekhuang@163.com>
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Nov 16, 2023
@ABingHuang
[BugFix] fix query_excluding_mv_names and query_including_mv_names bu…
84af6e6 
…gs (StarRocks#34873)

1. when query_including_mv_names is not set, should consider all related mvs
2. add trim for mv names for better usability

Signed-off-by: ABingHuang <codekhuang@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imay imay imay left review comments

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@LiShuMing LiShuMing LiShuMing approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

@ABingHuang ABingHuang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

when query_excluding_mv_names is set without setting query_including_mv_names, mv rewrite will fail
4 participants
@ABingHuang @imay @LiShuMing @kangkaisen