Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix several bugs of pipe #34871

Merged
merged 8 commits into from
Nov 14, 2023
Merged

[BugFix] fix several bugs of pipe #34871

merged 8 commits into from
Nov 14, 2023

Conversation

murphyatwork
Copy link
Contributor

@murphyatwork murphyatwork commented Nov 13, 2023 •
edited
Loading

Why I'm doing:

What I'm doing:

  1. Check insert privilege when creating pipe
  2. Fix display pipes.created_time
  3. Fix display pipes.last_error

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@murphyatwork murphyatwork requested review from a team as code owners November 13, 2023 09:34
@github-actions github-actions bot added the 3.2 label Nov 13, 2023
@murphyatwork
Copy link
Contributor Author

@Mergifyio rebase

@murphyatwork murphyatwork enabled auto-merge (squash) November 14, 2023 03:10
@murphyatwork
check insert privilege for create pipej
88265bb 
Signed-off-by: Murphy <mofei@starrocks.com>
@murphyatwork
pipe.created_time should use epoch second
415b455 
Signed-off-by: Murphy <mofei@starrocks.com>
@murphyatwork
disable html escaping
204d11f 
Signed-off-by: Murphy <mofei@starrocks.com>
@murphyatwork
fix error message
739336e 
Signed-off-by: Murphy <mofei@starrocks.com>
@murphyatwork
change file state when suspending
d2a82fc 
Signed-off-by: Murphy <mofei@starrocks.com>
@murphyatwork
fix comment
af28973 
Signed-off-by: Murphy <mofei@starrocks.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023

rebase

✅ Branch has been successfully rebased

@murphyatwork
fix test
3e000e2 
Signed-off-by: Murphy <mofei@starrocks.com>
@murphyatwork
fix test
c91ac39 
Signed-off-by: Murphy <mofei@starrocks.com>
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 17 / 19 (89.47%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/load/pipe/PipeTaskDesc.java 2 3 66.67% [117]
🔵 com/starrocks/load/pipe/Pipe.java 8 9 88.89% [519]
🔵 com/starrocks/common/util/TimeUtils.java 1 1 100.00% []
🔵 com/starrocks/sql/ast/pipe/ShowPipeStmt.java 1 1 100.00% []
🔵 com/starrocks/common/util/DateUtils.java 2 2 100.00% []
🔵 com/starrocks/sql/analyzer/AuthorizerStmtVisitor.java 1 1 100.00% []
🔵 com/starrocks/qe/ShowExecutor.java 2 2 100.00% []

@murphyatwork murphyatwork merged commit 31b9a33 into StarRocks:main Nov 14, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 14, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@murphyatwork @mergify
[BugFix] fix several bugs of pipe (#34871)
f021f87 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 31b9a33)
@mergify mergify bot mentioned this pull request Nov 14, 2023
Merged
packy92
packy92 reviewed Nov 14, 2023
View reviewed changes
fe/fe-core/src/main/java/com/starrocks/load/pipe/Pipe.java
}
loadStatus.loadingFiles = 0;

// Change LOADING files to UNLOADED
if (CollectionUtils.isNotEmpty(loadingFiles)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean?

wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2023
@murphyatwork @wanpengfei-git
[BugFix] fix several bugs of pipe (#34871)
3256a74 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 31b9a33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imay imay imay left review comments

@packy92 packy92 packy92 left review comments

@satanson satanson satanson approved these changes

@Seaven Seaven Seaven approved these changes

Assignees

@murphyatwork murphyatwork

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@murphyatwork @imay @satanson @Seaven @packy92 @wanpengfei-git