Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Check meta size enough for BDB Log #34813

Merged
merged 4 commits into from
Nov 14, 2023
Merged

[Enhancement] Check meta size enough for BDB Log #34813

merged 4 commits into from
Nov 14, 2023

Conversation

gengjun-git
Copy link
Contributor

@gengjun-git gengjun-git commented Nov 10, 2023 •
edited by jaogoy
Loading

For the new version of BDB (18.3.13), the available disk size is limited: at least 5G. If there is not enough space, BDB will fail to start, but the error log is only printed in bdb/je.info.0, so this enhancement checks the available disk size before starting bdb, which makes the log easy to find the cause of the failure.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@gengjun-git
init
9866086 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
@gengjun-git
fix
9a0d876 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
@gengjun-git
fix
deb3c62 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
@imay
Copy link
Contributor

imay commented Nov 10, 2023

Could you explain what problem you are trying to resolve with this CL?

@gengjun-git
enhance
2637a2f 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

❌ fail : 3 / 5 (60.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/leader/MetaHelper.java 3 5 60.00% [173, 175]

@gengjun-git gengjun-git enabled auto-merge (squash) November 14, 2023 06:34
@wanpengfei-git wanpengfei-git merged commit 32e8b05 into StarRocks:main Nov 14, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 14, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Nov 14, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@github-actions github-actions bot removed the 3.0 label Nov 14, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@gengjun-git @mergify
[Enhancement] Check meta size enough for BDB Log (#34813)
4cd17f6 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
(cherry picked from commit 32e8b05)
mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@gengjun-git @mergify
[Enhancement] Check meta size enough for BDB Log (#34813)
df8ffb6 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
(cherry picked from commit 32e8b05)
This was referenced Nov 14, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@gengjun-git @mergify
[Enhancement] Check meta size enough for BDB Log (#34813)
01392e4 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
(cherry picked from commit 32e8b05)
@mergify mergify bot mentioned this pull request Nov 14, 2023
Merged
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2023
@gengjun-git @wanpengfei-git
[Enhancement] Check meta size enough for BDB Log (#34813)
5733534 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
(cherry picked from commit 32e8b05)
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2023
@gengjun-git @wanpengfei-git
[Enhancement] Check meta size enough for BDB Log (#34813)
5718f73 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
(cherry picked from commit 32e8b05)
gengjun-git added a commit that referenced this pull request Nov 14, 2023
@gengjun-git
[Enhancement] Check meta size enough for BDB Log (#34813)
23cdfeb 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
(cherry picked from commit 32e8b05)
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2023
@gengjun-git @wanpengfei-git
[Enhancement] Check meta size enough for BDB Log (#34813)
c4e0784 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
(cherry picked from commit 32e8b05)
@yuxiqian yuxiqian mentioned this pull request Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshangyiming nshangyiming nshangyiming left review comments

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@Astralidea Astralidea Astralidea approved these changes

@HangyuanLiu HangyuanLiu HangyuanLiu approved these changes

Assignees

@gengjun-git gengjun-git

Labels
3.0 3.1 3.2 backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gengjun-git @imay @Astralidea @HangyuanLiu @nshangyiming @wanpengfei-git