Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Disable DiskAndTabletLoadReBalancer in shared data mode #34794

Merged
merged 2 commits into from
Nov 14, 2023
Merged

[Enhancement] Disable DiskAndTabletLoadReBalancer in shared data mode #34794

merged 2 commits into from
Nov 14, 2023

Conversation

sduzh
Copy link
Contributor

@sduzh sduzh commented Nov 10, 2023 •
edited
Loading

Does not run DiskAndTabletLoadReBalancer in shared data mode to reduce database lock contention.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@sduzh sduzh enabled auto-merge (squash) November 10, 2023 09:59
@github-actions github-actions bot added the 3.2 label Nov 10, 2023
@mergify mergify bot assigned sduzh Nov 10, 2023
@sduzh sduzh disabled auto-merge November 10, 2023 09:59
@sduzh sduzh enabled auto-merge (squash) November 10, 2023 10:00
gengjun-git
gengjun-git previously approved these changes Nov 10, 2023
View reviewed changes
@sduzh
Copy link
Contributor Author

sduzh commented Nov 13, 2023

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 13, 2023

rebase

✅ Branch has been successfully rebased

@sduzh sduzh force-pushed the enhancement/reduce-db-lock-disk-balancer branch from 10bba61 to c27d2f3 Compare November 13, 2023 03:09
@sduzh
Copy link
Contributor Author

sduzh commented Nov 13, 2023

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 13, 2023

rebase

✅ Branch has been successfully rebased

@sduzh sduzh force-pushed the enhancement/reduce-db-lock-disk-balancer branch from c27d2f3 to a8e877c Compare November 13, 2023 11:58
@sduzh
Copy link
Contributor Author

sduzh commented Nov 14, 2023

@Mergifyio rebase

sduzh added 2 commits November 14, 2023 02:00
@sduzh
[Enhancement] Disable DiskAndTabletLoadReBalancer in shared data mode
aa69cb3 
Does not run DiskAndTabletLoadReBalancer in shared data mode to avoid
unnecessary database lock contention.

Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
@sduzh
[Refactor] refactor
35fee07 
Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023

rebase

✅ Branch has been successfully rebased

@sduzh sduzh force-pushed the enhancement/reduce-db-lock-disk-balancer branch from a8e877c to 35fee07 Compare November 14, 2023 02:00
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/clone/DiskAndTabletLoadReBalancer.java 2 2 100.00% []

@sduzh sduzh merged commit 5390b04 into StarRocks:main Nov 14, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 14, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Nov 14, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@github-actions github-actions bot removed the 3.0 label Nov 14, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@sduzh @mergify
[Enhancement] Disable DiskAndTabletLoadReBalancer in shared data mode (…
1a14eb5 
…#34794)

Does not run DiskAndTabletLoadReBalancer in shared data mode to reduce database lock contention.

Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
(cherry picked from commit 5390b04)
@mergify mergify bot mentioned this pull request Nov 14, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@sduzh @mergify
[Enhancement] Disable DiskAndTabletLoadReBalancer in shared data mode (…
09b33cc 
…#34794)

Does not run DiskAndTabletLoadReBalancer in shared data mode to reduce database lock contention.

Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
(cherry picked from commit 5390b04)
@mergify mergify bot mentioned this pull request Nov 14, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@sduzh @mergify
[Enhancement] Disable DiskAndTabletLoadReBalancer in shared data mode (…
9803e56 
…#34794)

Does not run DiskAndTabletLoadReBalancer in shared data mode to reduce database lock contention.

Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
(cherry picked from commit 5390b04)
@mergify mergify bot mentioned this pull request Nov 14, 2023
Merged
@sduzh sduzh deleted the enhancement/reduce-db-lock-disk-balancer branch November 14, 2023 06:09
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2023
@sduzh @wanpengfei-git
[Enhancement] Disable DiskAndTabletLoadReBalancer in shared data mode (…
381a2a2 
…#34794)

Does not run DiskAndTabletLoadReBalancer in shared data mode to reduce database lock contention.

Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
(cherry picked from commit 5390b04)
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2023
@sduzh @wanpengfei-git
[Enhancement] Disable DiskAndTabletLoadReBalancer in shared data mode (…
ccc4ad9 
…#34794)

Does not run DiskAndTabletLoadReBalancer in shared data mode to reduce database lock contention.

Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
(cherry picked from commit 5390b04)
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2023
@sduzh @wanpengfei-git
[Enhancement] Disable DiskAndTabletLoadReBalancer in shared data mode (…
a640919 
…#34794)

Does not run DiskAndTabletLoadReBalancer in shared data mode to reduce database lock contention.

Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
(cherry picked from commit 5390b04)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imay imay imay left review comments

@kevincai kevincai kevincai approved these changes

@Astralidea Astralidea Astralidea approved these changes

@gengjun-git gengjun-git gengjun-git approved these changes

@wyb wyb Awaiting requested review from wyb

Assignees

@sduzh sduzh

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sduzh @kevincai @imay @Astralidea @gengjun-git @wanpengfei-git