Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] abort transaction without database lock #34790

Merged
merged 1 commit into from
Nov 10, 2023
Merged

[Enhancement] abort transaction without database lock #34790

merged 1 commit into from
Nov 10, 2023

Conversation

sduzh
Copy link
Contributor

@sduzh sduzh commented Nov 10, 2023 •
edited
Loading

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@mergify mergify bot assigned sduzh Nov 10, 2023
@sduzh
[Enhancement] Abort transaction without database lock
8ea9b5d 
Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
@sduzh sduzh force-pushed the enhancement/reduce-db-lock branch from ee72729 to 8ea9b5d Compare November 10, 2023 09:08
@sduzh sduzh enabled auto-merge (squash) November 10, 2023 09:10
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 7 / 7 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/transaction/DatabaseTransactionMgr.java 7 7 100.00% []

@sduzh sduzh merged commit 50447b1 into StarRocks:main Nov 10, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 10, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Nov 10, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 10, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@github-actions github-actions bot removed the 3.0 label Nov 10, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 10, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@github-actions github-actions bot removed the 2.5 label Nov 10, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 10, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 10, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 10, 2023
@sduzh @mergify
[Enhancement] abort transaction without database lock (#34790)
f57d2a6 
Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
(cherry picked from commit 50447b1)
mergify bot pushed a commit that referenced this pull request Nov 10, 2023
@sduzh @mergify
[Enhancement] abort transaction without database lock (#34790)
1764aac 
Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
(cherry picked from commit 50447b1)
@mergify mergify bot mentioned this pull request Nov 10, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 10, 2023
@sduzh @mergify
[Enhancement] abort transaction without database lock (#34790)
dd4b1c8 
Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
(cherry picked from commit 50447b1)
This was referenced Nov 10, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Nov 10, 2023
@sduzh @mergify
[Enhancement] abort transaction without database lock (#34790)
a5813b7 
Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
(cherry picked from commit 50447b1)
@mergify mergify bot mentioned this pull request Nov 10, 2023
Merged
wanpengfei-git pushed a commit that referenced this pull request Nov 10, 2023
@sduzh @wanpengfei-git
[Enhancement] abort transaction without database lock (#34790)
35af56c 
Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
(cherry picked from commit 50447b1)
wanpengfei-git pushed a commit that referenced this pull request Nov 10, 2023
@sduzh @wanpengfei-git
[Enhancement] abort transaction without database lock (#34790)
35b8c20 
Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
(cherry picked from commit 50447b1)
wanpengfei-git pushed a commit that referenced this pull request Nov 10, 2023
@sduzh @wanpengfei-git
[Enhancement] abort transaction without database lock (#34790)
7a3dcd7 
Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
(cherry picked from commit 50447b1)
wanpengfei-git pushed a commit that referenced this pull request Nov 10, 2023
@sduzh @wanpengfei-git
[Enhancement] abort transaction without database lock (#34790)
d408b76 
Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
(cherry picked from commit 50447b1)
@sduzh sduzh deleted the enhancement/reduce-db-lock branch December 4, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@kevincai kevincai kevincai approved these changes

@wyb wyb wyb approved these changes

@gengjun-git gengjun-git gengjun-git approved these changes

@nshangyiming nshangyiming Awaiting requested review from nshangyiming

Assignees

@sduzh sduzh

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sduzh @kevincai @wyb @gengjun-git @jaogoy @wanpengfei-git