Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Automatically create partition table to support insert overwrite by partition name #34777

Merged
merged 2 commits into from
Nov 14, 2023
Merged

[Enhancement] Automatically create partition table to support insert overwrite by partition name #34777

merged 2 commits into from
Nov 14, 2023

Conversation

Astralidea
Copy link
Contributor

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@Astralidea
Automatically create partition table to support insert overwrite by p…
081ff8b 
…artition name

Signed-off-by: Astralidea <astralidea@163.com>
@Astralidea
Opt.
69aae3d 
Signed-off-by: Astralidea <astralidea@163.com>
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 28 / 32 (87.50%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/load/InsertOverwriteJobRunner.java 28 32 87.50% [243, 244, 257, 270]

@Astralidea Astralidea enabled auto-merge (squash) November 10, 2023 11:05
@Astralidea Astralidea merged commit 7c6884e into StarRocks:main Nov 14, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 14, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@github-actions github-actions bot removed the 3.1 label Nov 14, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@github-actions github-actions bot removed the 3.0 label Nov 14, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@Astralidea @mergify
[Enhancement] Automatically create partition table to support insert …
46ac038 
…overwrite by partition name (#34777)

Signed-off-by: Astralidea <astralidea@163.com>
(cherry picked from commit 7c6884e)
@mergify mergify bot mentioned this pull request Nov 14, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@Astralidea @mergify
[Enhancement] Automatically create partition table to support insert …
c1a6c9e 
…overwrite by partition name (#34777)

Signed-off-by: Astralidea <astralidea@163.com>
(cherry picked from commit 7c6884e)
@mergify mergify bot mentioned this pull request Nov 14, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@Astralidea @mergify
[Enhancement] Automatically create partition table to support insert …
c5a51be 
…overwrite by partition name (#34777)

Signed-off-by: Astralidea <astralidea@163.com>
(cherry picked from commit 7c6884e)

# Conflicts:
#	test/sql/test_automatic_partition/R/test_insert_overwrite
#	test/sql/test_automatic_partition/T/test_insert_overwrite
@mergify mergify bot mentioned this pull request Nov 14, 2023
Closed
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2023
@Astralidea @wanpengfei-git
[Enhancement] Automatically create partition table to support insert …
524e576 
…overwrite by partition name (#34777)

Signed-off-by: Astralidea <astralidea@163.com>
(cherry picked from commit 7c6884e)
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2023
@Astralidea @wanpengfei-git
[Enhancement] Automatically create partition table to support insert …
70f340c 
…overwrite by partition name (#34777)

Signed-off-by: Astralidea <astralidea@163.com>
(cherry picked from commit 7c6884e)
@Astralidea Astralidea mentioned this pull request Nov 14, 2023
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@gengjun-git gengjun-git gengjun-git approved these changes

@stephen-shelby stephen-shelby stephen-shelby approved these changes

Assignees

@Astralidea Astralidea

Labels
backport_ok behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Astralidea @gengjun-git @stephen-shelby @wanpengfei-git