Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] remove threadLocal after operation #34758

Merged
merged 1 commit into from
Nov 15, 2023
Merged

[BugFix] remove threadLocal after operation #34758

merged 1 commit into from
Nov 15, 2023

Conversation

packy92
Copy link
Contributor

@packy92 packy92 commented Nov 10, 2023 •
edited
Loading

Fixes #issue
remove threadLocal after operation to avoid memory leak.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@packy92
[BugFix] remove threadLocal after operation
5dd71dc 
Signed-off-by: packy92 <wangchao@starrocks.com>
@packy92 packy92 requested a review from a team as a code owner November 10, 2023 07:07
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
20.7% 20.7% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

❌ fail : 10 / 13 (76.92%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/statistics/ColumnHistogramStatsCacheLoader.java 0 2 00.00% [79, 113]
🔵 com/starrocks/sql/optimizer/statistics/TableStatsCacheLoader.java 1 2 50.00% [54]
🔵 com/starrocks/http/BaseAction.java 1 1 100.00% []
🔵 com/starrocks/connector/ConnectorColumnStatsCacheLoader.java 2 2 100.00% []
🔵 com/starrocks/qe/StmtExecutor.java 2 2 100.00% []
🔵 com/starrocks/scheduler/TaskRunExecutor.java 1 1 100.00% []
🔵 com/starrocks/http/rest/ExecuteSqlAction.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/statistics/ColumnBasicStatsCacheLoader.java 2 2 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@Seaven Seaven enabled auto-merge (squash) November 14, 2023 06:34
@kangkaisen kangkaisen disabled auto-merge November 15, 2023 01:49
@kangkaisen kangkaisen merged commit 32ff703 into StarRocks:main Nov 15, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Nov 15, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 15, 2023
@packy92 @mergify
[BugFix] remove threadLocal after operation (#34758)
7cf134e 
Signed-off-by: packy92 <wangchao@starrocks.com>
(cherry picked from commit 32ff703)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/connector/ConnectorColumnStatsCacheLoader.java
#	fe/fe-core/src/main/java/com/starrocks/http/BaseAction.java
#	fe/fe-core/src/main/java/com/starrocks/http/rest/ExecuteSqlAction.java
mergify bot pushed a commit that referenced this pull request Nov 15, 2023
@packy92 @mergify
[BugFix] remove threadLocal after operation (#34758)
60c546b 
Signed-off-by: packy92 <wangchao@starrocks.com>
(cherry picked from commit 32ff703)
This was referenced Nov 15, 2023
Closed
Closed
mergify bot pushed a commit that referenced this pull request Nov 15, 2023
@packy92 @mergify
[BugFix] remove threadLocal after operation (#34758)
0b1cf5e 
Signed-off-by: packy92 <wangchao@starrocks.com>
(cherry picked from commit 32ff703)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/connector/ConnectorColumnStatsCacheLoader.java
#	fe/fe-core/src/main/java/com/starrocks/http/BaseAction.java
#	fe/fe-core/src/main/java/com/starrocks/http/rest/ExecuteSqlAction.java
@mergify mergify bot mentioned this pull request Nov 15, 2023
Closed
packy92 added a commit to packy92/starrocks that referenced this pull request Nov 18, 2023
@packy92
[BugFix] remove threadLocal after operation (StarRocks#34758)
40982f0 
Signed-off-by: packy92 <wangchao@starrocks.com>
packy92 added a commit to packy92/starrocks that referenced this pull request Nov 18, 2023
@packy92
[BugFix] remove threadLocal after operation (StarRocks#34758)
f002277 
Signed-off-by: packy92 <wangchao@starrocks.com>
packy92 added a commit to packy92/starrocks that referenced this pull request Nov 18, 2023
@packy92
[BugFix] remove threadLocal after operation (StarRocks#34758)
8e4414a 
Signed-off-by: packy92 <wangchao@starrocks.com>
@packy92 packy92 mentioned this pull request Nov 18, 2023
Merged
22 tasks
packy92 added a commit to packy92/starrocks that referenced this pull request Nov 18, 2023
@packy92
[BugFix] remove threadLocal after operation (StarRocks#34758)
ac1b996 
Signed-off-by: packy92 <wangchao@starrocks.com>
packy92 added a commit to packy92/starrocks that referenced this pull request Nov 18, 2023
@packy92
[BugFix] remove threadLocal after operation (StarRocks#34758)
8267463 
Signed-off-by: packy92 <wangchao@starrocks.com>
packy92 added a commit that referenced this pull request Nov 22, 2023
@packy92
[BugFix] remove threadLocal after operation (backport #34758) (#35344)
458bb59 
Signed-off-by: packy92 <wangchao@starrocks.com>
packy92 added a commit that referenced this pull request Nov 22, 2023
@packy92
[BugFix] remove threadLocal after operation (backport #34758) (#35343)
813b513 
Signed-off-by: packy92 <wangchao@starrocks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satanson satanson satanson approved these changes

@Seaven Seaven Seaven approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

@packy92 packy92

Labels
3.1 3.2 backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@packy92 @satanson @Seaven @kangkaisen @wanpengfei-git