Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] refactor connector specific interfaces in mv #34681

Merged
merged 3 commits into from
Nov 10, 2023
Merged

[Refactor] refactor connector specific interfaces in mv #34681

merged 3 commits into from
Nov 10, 2023

Conversation

murphyatwork
Copy link
Contributor

@murphyatwork murphyatwork commented Nov 9, 2023 •
edited
Loading

Fixes #issue

Refactor interfaces into ConnectorPartitionTraits:

  • maxPartitionRefreshTs
  • getUpdatedPartitionNames

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@murphyatwork
refactor Traits.maxPartitionRefreshTs
d703cb5 
Signed-off-by: Murphy <mofei@starrocks.com>
@murphyatwork
refactor Traits.getUpdatedPartitionNames
4649152 
Signed-off-by: Murphy <mofei@starrocks.com>
@murphyatwork murphyatwork force-pushed the murphy_fix_iceberg_staleness branch from ce3bf53 to 4649152 Compare November 9, 2023 11:23
satanson
satanson previously approved these changes Nov 9, 2023
View reviewed changes
imay
imay reviewed Nov 10, 2023
View reviewed changes
fe/fe-core/src/main/java/com/starrocks/connector/ConnectorPartitionTraits.java
public Set<String> getUpdatedPartitionNames(MaterializedView mv) {
// TODO: implement
return null;
}
}

static class IcebergPartitionTraits extends DefaultTraits {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is time to move all specific implementations into separate files. Can do it later.

fe/fe-core/src/main/java/com/starrocks/connector/ConnectorPartitionTraits.java Outdated
}

@Override
public Set<String> getUpdatedPartitionNames(MaterializedView mv) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MV contains a lot of information, is it necessary to make the entire MV as the argument?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@murphyatwork
simplify getUpdatedPartitionNames interface
7207973 
Signed-off-by: Murphy <mofei@starrocks.com>
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@murphyatwork murphyatwork enabled auto-merge (squash) November 10, 2023 04:52
@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 104 / 119 (87.39%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/MaterializedView.java 21 24 87.50% [126, 626, 686]
🔵 com/starrocks/connector/ConnectorPartitionTraits.java 83 95 87.37% [230, 335, 397, 420, 421, 484, 520, 521, 522, 523, 524, 544]

@murphyatwork murphyatwork merged commit 4374a6c into StarRocks:main Nov 10, 2023
@murphyatwork
Copy link
Contributor Author

@Mergifyio backport branch-3.0 branch-3.1 branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 10, 2023 •
edited
Loading

backport branch-3.0 branch-3.1 branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 10, 2023
@murphyatwork @mergify
[Refactor] refactor connector specific interfaces in mv (#34681)
0af4160 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 4374a6c)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/MaterializedView.java
#	fe/fe-core/src/main/java/com/starrocks/connector/ConnectorPartitionTraits.java
@mergify mergify bot mentioned this pull request Nov 10, 2023
Closed
mergify bot pushed a commit that referenced this pull request Nov 10, 2023
@murphyatwork @mergify
[Refactor] refactor connector specific interfaces in mv (#34681)
5de72e6 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 4374a6c)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/MaterializedView.java
#	fe/fe-core/src/main/java/com/starrocks/connector/ConnectorPartitionTraits.java
@mergify mergify bot mentioned this pull request Nov 10, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 10, 2023
@murphyatwork @mergify
[Refactor] refactor connector specific interfaces in mv (#34681)
dc89238 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 4374a6c)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/MaterializedView.java
@mergify mergify bot mentioned this pull request Nov 10, 2023
Merged
wanpengfei-git pushed a commit that referenced this pull request Nov 10, 2023
@murphyatwork @wanpengfei-git
[Refactor] refactor connector specific interfaces in mv (#34681)
a98c713 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 4374a6c)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/MaterializedView.java
wanpengfei-git pushed a commit that referenced this pull request Nov 10, 2023
@murphyatwork @wanpengfei-git
[Refactor] refactor connector specific interfaces in mv (#34681)
f2de49d 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 4374a6c)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/MaterializedView.java
#	fe/fe-core/src/main/java/com/starrocks/connector/ConnectorPartitionTraits.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imay imay imay left review comments

@satanson satanson satanson approved these changes

@LiShuMing LiShuMing LiShuMing approved these changes

Assignees

@murphyatwork murphyatwork

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@murphyatwork @imay @satanson @LiShuMing @wanpengfei-git