Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Txn timeout too fast if not specify timeout in http header #34544

Merged
merged 2 commits into from
Nov 16, 2023
Merged

[BugFix] Txn timeout too fast if not specify timeout in http header #34544

merged 2 commits into from
Nov 16, 2023

Conversation

smartlxh
Copy link
Contributor

@smartlxh smartlxh commented Nov 8, 2023 •
edited
Loading

Txn will timeout too fast or begin txn fail. The reason is that the default timeout unit is seconds, but it was mistakenly regarded as milliseconds.

"Message": "STREAM_LOAD_TASK:125028, label{decb0914-6ab4-4474-8bf9-c2474e11be21}, error_msg{cancel stream task for exception: Invalid timeout. Timeout should between 1 and 259200 seconds}",

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@smartlxh smartlxh changed the title [Bugfix] Txn timeout too fast if not specify timeout in http header [BugFix] Txn timeout too fast if not specify timeout in http header Nov 8, 2023
@banmoy
Copy link
Contributor

banmoy commented Nov 8, 2023

Should add a SQL Test to verify it

kangkaisen
kangkaisen previously approved these changes Nov 9, 2023
View reviewed changes
caneGuy
caneGuy previously approved these changes Nov 11, 2023
View reviewed changes
@caneGuy caneGuy enabled auto-merge (squash) November 11, 2023 10:56
auto-merge was automatically disabled November 13, 2023 03:24

Head branch was pushed to by a user without write access

@smartlxh smartlxh dismissed stale reviews from caneGuy and kangkaisen via 2d63044 November 13, 2023 03:24
@CLAassistant
Copy link

CLAassistant commented Nov 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ smartlxh
❌ lixianhai

lixianhai seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@smartlxh smartlxh force-pushed the bugfix_timeout branch 5 times, most recently from 322699a to 3ec9962 Compare November 13, 2023 12:00
@smartlxh
Txn timeout too fast if not specify timeout in http header
6febfd7 
Txn  will timeout too fast if not specify `timeout` in http header by stream load. The reason is that the default timeout unit is seconds, but it was mistakenly regarded as milliseconds
Link: https://code.alibaba-inc.com/soe/starrocks/codereview/13246218
* bugfix: txn timeout too fast if not specify `timeout` in http header,

Signed-off-by: lixianhai <lixianhai.lxh@alibaba-inc.com>
@smartlxh
add ut
9243322 
Signed-off-by: lixianhai <lixianhai.lxh@alibaba-inc.com>
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/service/FrontendServiceImpl.java 1 1 100.00% []

@github-actions github-actions bot added the 3.0 label Nov 14, 2023
@caneGuy caneGuy merged commit eb806a1 into StarRocks:main Nov 16, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 16, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Nov 16, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 16, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Nov 16, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 16, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@github-actions github-actions bot removed the 2.5 label Nov 16, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 16, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 16, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 16, 2023
@smartlxh @mergify
[BugFix] Txn timeout too fast if not specify timeout in http header (…
830da92 
…#34544)

Signed-off-by: lixianhai <lixianhai.lxh@alibaba-inc.com>
(cherry picked from commit eb806a1)
@mergify mergify bot mentioned this pull request Nov 16, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 16, 2023
@smartlxh @mergify
[BugFix] Txn timeout too fast if not specify timeout in http header (…
b89481a 
…#34544)

Signed-off-by: lixianhai <lixianhai.lxh@alibaba-inc.com>
(cherry picked from commit eb806a1)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/service/FrontendServiceImplTest.java
@mergify mergify bot mentioned this pull request Nov 16, 2023
Closed
mergify bot pushed a commit that referenced this pull request Nov 16, 2023
@smartlxh @mergify
[BugFix] Txn timeout too fast if not specify timeout in http header (…
db28b64 
…#34544)

Signed-off-by: lixianhai <lixianhai.lxh@alibaba-inc.com>
(cherry picked from commit eb806a1)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java
#	fe/fe-core/src/test/java/com/starrocks/service/FrontendServiceImplTest.java
@mergify mergify bot mentioned this pull request Nov 16, 2023
Closed
mergify bot pushed a commit that referenced this pull request Nov 16, 2023
@smartlxh @mergify
[BugFix] Txn timeout too fast if not specify timeout in http header (…
a7f699c 
…#34544)

Signed-off-by: lixianhai <lixianhai.lxh@alibaba-inc.com>
(cherry picked from commit eb806a1)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java
#	fe/fe-core/src/test/java/com/starrocks/service/FrontendServiceImplTest.java
@mergify mergify bot mentioned this pull request Nov 16, 2023
Closed
@smartlxh smartlxh mentioned this pull request Nov 16, 2023
Merged
22 tasks
wanpengfei-git pushed a commit that referenced this pull request Nov 16, 2023
@smartlxh @wanpengfei-git
[BugFix] Txn timeout too fast if not specify timeout in http header (…
a4e6894 
…#34544)

Signed-off-by: lixianhai <lixianhai.lxh@alibaba-inc.com>
(cherry picked from commit eb806a1)
meegoo pushed a commit that referenced this pull request Nov 16, 2023
@smartlxh
[BugFix]Txn timeout too fast if not specify timeout in http header (b…
c3a88a4 
…ackport #34544) (#35188)

Signed-off-by: lixianhai <lixianhai.lxh@alibaba-inc.com>
@evelynzhaojie
Copy link
Contributor

would you pls add the meaning of enable_load_profile to documentation: https://github.com/StarRocks/starrocks/blob/main/docs/en/reference/System_variable.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miomiocat miomiocat miomiocat approved these changes

@caneGuy caneGuy caneGuy approved these changes

@kangkaisen kangkaisen kangkaisen left review comments

Assignees

@smartlxh smartlxh

Labels
3.1 3.2 backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@smartlxh @banmoy @CLAassistant @evelynzhaojie @kangkaisen @miomiocat @caneGuy @wanpengfei-git