Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Avoid checking group concurrency_limit when enabling group level queue (backport #34398) #34479

Merged
merged 2 commits into from
Nov 7, 2023
Merged

[Enhancement] Avoid checking group concurrency_limit when enabling group level queue (backport #34398) #34479

merged 2 commits into from
Nov 7, 2023

Conversation

ZiheLiu
Copy link
Contributor

@ZiheLiu ZiheLiu commented Nov 7, 2023

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@ZiheLiu
[Enhancement] Avoid checking group concurrency_limit when enabling gr…
7068d08 
…oup level queue (StarRocks#34398)

Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
@ZiheLiu
s
0abdb5e 
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
@ZiheLiu ZiheLiu changed the title Opt/3.1/group level queue concurrency limit merge [Enhancement] Avoid checking group concurrency_limit when enabling group level queue (backport #34398) Nov 7, 2023
@ZiheLiu ZiheLiu enabled auto-merge (squash) November 7, 2023 03:20
@ZiheLiu ZiheLiu disabled auto-merge November 7, 2023 03:20
@mergify mergify bot assigned ZiheLiu Nov 7, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

[FE Incremental Coverage Report]

❌ fail : 17 / 23 (73.91%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/CoordinatorPreprocessor.java 12 18 66.67% [402, 1726, 1727, 1728, 1730, 1731]
🔵 com/starrocks/qe/QueryQueueManager.java 5 5 100.00% []

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

[BE Incremental Coverage Report]

❌ fail : 4 / 15 (26.67%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/exec/workgroup/work_group.cpp 0 3 00.00% [199, 201, 202]
🔵 src/exec/pipeline/fragment_executor.cpp 0 7 00.00% [192, 195, 196, 197, 198, 199, 200]
🔵 src/exec/workgroup/work_group.h 0 1 00.00% [190]
🔵 src/exec/pipeline/query_context.cpp 3 3 100.00% []
🔵 src/exec/pipeline/query_context.h 1 1 100.00% []

@kangkaisen kangkaisen merged commit 1dcb2b1 into StarRocks:branch-3.1 Nov 7, 2023
@luohaha
Copy link
Contributor

luohaha commented Jan 12, 2024

https://github.com/Mergifyio backport branch-3.1-cs

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 12, 2024 •
edited
Loading

backport branch-3.1-cs

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 12, 2024
@ZiheLiu @mergify
[Enhancement] Avoid checking group concurrency_limit when enabling gr…
aaf1ad2 
…oup level queue (backport #34398) (#34479)

Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
(cherry picked from commit 1dcb2b1)

# Conflicts:
#	gensrc/thrift/InternalService.thrift
@mergify mergify bot mentioned this pull request Jan 12, 2024
Closed
luohaha pushed a commit to luohaha/starrocks that referenced this pull request Jan 12, 2024
@ZiheLiu @luohaha
[Enhancement] Avoid checking group concurrency_limit when enabling gr…
0feada3 
…oup level queue (backport StarRocks#34398) (StarRocks#34479)

Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
luohaha pushed a commit to luohaha/starrocks that referenced this pull request Jan 13, 2024
@ZiheLiu @luohaha
[Enhancement] Avoid checking group concurrency_limit when enabling gr…
0183a6c 
…oup level queue (backport StarRocks#34398) (StarRocks#34479)

Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
andyziye pushed a commit that referenced this pull request Jan 13, 2024
@luohaha
[Enhancement] Avoid checking group concurrency_limit when enabling gr…
f4095e9 
…oup level queue (backport #34398) (#34479) (#39027)

Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

@ZiheLiu ZiheLiu

Labels
title needs [type]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZiheLiu @luohaha @kangkaisen