Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Rename light schema change to fast schema evolution #34472

Merged
merged 9 commits into from
Nov 13, 2023
Merged

[Refactor] Rename light schema change to fast schema evolution #34472

merged 9 commits into from
Nov 13, 2023

Conversation

sevev
Copy link
Contributor

@sevev sevev commented Nov 7, 2023 •
edited
Loading

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@sevev sevev requested a review from a team as a code owner November 7, 2023 02:47
@mergify mergify bot assigned sevev Nov 7, 2023
@sevev sevev changed the title [Refactor] Rename light schema change to fast schema evolution [WIP][Refactor] Rename light schema change to fast schema evolution Nov 7, 2023
@sevev sevev changed the title [WIP][Refactor] Rename light schema change to fast schema evolution [Refactor] Rename light schema change to fast schema evolution Nov 8, 2023
sevev added 6 commits November 10, 2023 13:42
@sevev
Refactor: Rename light schema change to fast schema evolution
9863b3b 
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
@sevev
update
b0b90c7 
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
@sevev
update
5fdd882 
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
@sevev
property compatible with light_schema_change
d580121 
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
@sevev
update
ea799f6 
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
@sevev
update
c34b326 
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
sevev added 2 commits November 10, 2023 16:30
@sevev
update
35b19f8 
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
@sevev
update
acd2c8b 
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
wyb
wyb previously approved these changes Nov 10, 2023
View reviewed changes
@wyb wyb enabled auto-merge (squash) November 10, 2023 09:31
@sevev
update sql test
df78471 
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

0.0% 0.0% Coverage
2.2% 2.2% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 48 / 59 (81.36%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/MaterializedView.java 0 1 00.00% [125]
🔵 com/starrocks/alter/SchemaChangeHandler.java 22 31 70.97% [329, 342, 363, 380, 397, 894, 907, 934, 1563]
🔵 com/starrocks/common/util/PropertyAnalyzer.java 6 7 85.71% [622]
🔵 com/starrocks/server/OlapTableFactory.java 6 6 100.00% []
🔵 com/starrocks/catalog/OlapTable.java 4 4 100.00% []
🔵 com/starrocks/common/Config.java 1 1 100.00% []
🔵 com/starrocks/sql/ast/MVColumnItem.java 2 2 100.00% []
🔵 com/starrocks/catalog/TableProperty.java 4 4 100.00% []
🔵 com/starrocks/server/GlobalStateMgr.java 3 3 100.00% []

@wyb wyb merged commit b24c6ed into StarRocks:main Nov 13, 2023
@sevev
Copy link
Contributor Author

sevev commented Nov 15, 2023

@mergify backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 15, 2023
@sevev @mergify
[Refactor] Rename light schema change to fast schema evolution (#34472)
f942bd7 
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit b24c6ed)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/common/Config.java
#	fe/fe-core/src/test/resources/sql/tpchcost/q1.sql
#	fe/fe-core/src/test/resources/sql/tpchcost/q20.sql
#	fe/fe-core/src/test/resources/sql/tpchcost/q5.sql
#	fe/fe-core/src/test/resources/sql/tpchcost/q7.sql
#	test/sql/test_add_column/R/test_add_column
#	test/sql/test_add_column/T/test_add_column
#	test/sql/test_column_rename/R/test_column_rename
#	test/sql/test_materialized_view/R/test_materialized_view_rewrite
#	test/sql/test_materialized_view/T/test_materialized_view_rewrite
@mergify mergify bot mentioned this pull request Nov 15, 2023
Closed
sevev added a commit to sevev/starrocks that referenced this pull request Nov 15, 2023
@sevev
[Refactor] Rename light schema change to fast schema evolution (StarR…
17a5ad0 
…ocks#34472)

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
sevev added a commit that referenced this pull request Nov 17, 2023
@sevev
[Refactor][Cherry-pick][Branch-3.2] Rename light schema change to fas…
74b60f7 
…t schema evolution (#34472) (#35110)

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decster decster decster approved these changes

@wyb wyb wyb approved these changes

@HangyuanLiu HangyuanLiu HangyuanLiu approved these changes

Assignees

@sevev sevev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sevev @decster @wyb @HangyuanLiu