Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][Enhancement] Support parquet pagecache based on datacache module. #34330

Open
wants to merge 3 commits into
base: branch-3.1-dla-optimize
Choose a base branch
from

Conversation

GavinMar
Copy link
Contributor

@GavinMar GavinMar commented Nov 3, 2023

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@GavinMar GavinMar force-pushed the footer_cache_opt branch 5 times, most recently from 3a6080d to 1839c7d Compare November 10, 2023 11:25
@GavinMar GavinMar force-pushed the footer_cache_opt branch 3 times, most recently from 559de3f to 781e1c7 Compare November 16, 2023 12:18
@GavinMar GavinMar force-pushed the footer_cache_opt branch 3 times, most recently from 9b4fc3e to b137b4e Compare December 4, 2023 09:30
@GavinMar GavinMar changed the title [Enhancement] Support parquet pagecache based on datacache module. [WIP][Enhancement] Support parquet pagecache based on datacache module. Dec 4, 2023
Copy link

github-actions bot commented Dec 4, 2023

[FE Incremental Coverage Report]

pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/SessionVariable.java 4 4 100.00% []

Signed-off-by: Gavin <yangguansuo@starrocks.com>
Signed-off-by: Gavin <yangguansuo@starrocks.com>
Signed-off-by: Gavin <yangguansuo@starrocks.com>
Copy link

[BE Incremental Coverage Report]

pass : 106 / 114 (92.98%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/formats/parquet/page_reader.h 0 1 00.00% [30]
🔵 src/connector/hive_connector.cpp 9 12 75.00% [94, 551, 552]
🔵 src/formats/parquet/page_reader.cpp 29 32 90.62% [41, 42, 43]
🔵 src/formats/parquet/file_reader.cpp 21 22 95.45% [117]
🔵 src/block_cache/block_cache.cpp 7 7 100.00% []
🔵 src/formats/parquet/column_chunk_reader.cpp 7 7 100.00% []
🔵 src/exec/hdfs_scanner_parquet.cpp 27 27 100.00% []
🔵 src/block_cache/io_buffer.h 1 1 100.00% []
🔵 src/exec/hdfs_scanner.cpp 2 2 100.00% []
🔵 src/block_cache/starcache_wrapper.cpp 2 2 100.00% []
🔵 src/formats/parquet/group_reader.cpp 1 1 100.00% []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant