Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix full outer join rewrite and nested mv refresh bug for 3.1-mv #34071

Merged
merged 2 commits into from
Nov 1, 2023
Merged

[BugFix] Fix full outer join rewrite and nested mv refresh bug for 3.1-mv #34071

merged 2 commits into from
Nov 1, 2023

Conversation

ABingHuang
Copy link
Contributor

@ABingHuang ABingHuang commented Oct 31, 2023 •
edited
Loading

For rewrite:

  1. fix join derivibility rewrite bug for multi joins query
  2. fix equivalence class construction bugs to exclude outer join on predicate, which should be rewritten by ReplaceColumnRefRewriter
  3. optimize predicate normalization to process column name's case
  4. set mv plan timeout to new_planner_optimize_timeout

For refresh:

  1. fix refresh on nested mv bug to process date format like %Y%m%d
  2. set strict mode to false for mv refresh

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@ABingHuang ABingHuang force-pushed the fix_full_outer_join_bug branch 2 times, most recently from 146df9c to 0d80aeb Compare November 1, 2023 06:12
@ABingHuang ABingHuang enabled auto-merge (squash) November 1, 2023 06:13
@ABingHuang
Fix full outer join rewrite and nested mv refresh bug
68a94e6 
For rewrite:
1. fix join derivibility rewrite bug for multi joins query
2. fix ec construction bugs to exclude outer join on predicate, which
   should be rewritten by ReplaceColumnRefRewriter
3. optimize predicate normalization to process column name's case
4. set mv plan timeout to new_planner_optimize_timeout
For refresh:
1. fix refresh on nested mv bug to process date format like %Y%m%d
2. set strict mode to false for mv refresh

Signed-off-by: ABingHuang <codekhuang@163.com>
Signed-off-by: Youngwb <yangwenbo_mailbox@163.com>
@ABingHuang ABingHuang force-pushed the fix_full_outer_join_bug branch from 0d80aeb to 68a94e6 Compare November 1, 2023 08:12
@ABingHuang
fix ut
e49d976 
Signed-off-by: ABingHuang <codekhuang@163.com>
@ABingHuang ABingHuang merged commit bdbc2c1 into StarRocks:branch-3.1-mv Nov 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

[FE Incremental Coverage Report]

❌ fail : 103 / 138 (74.64%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/MvUtils.java 3 29 10.34% [1075, 1080, 1097, 1098, 1099, 1101, 1107, 1108, 1109, 1110, 1111, 1113, 1114, 1115, 1116, 1117, 1118, 1119, 1120, 1121, 1122, 1123, 1124, 1125, 1126, 1128]
🔵 com/starrocks/scheduler/PartitionBasedMvRefreshProcessor.java 6 15 40.00% [1112, 1113, 1114, 1115, 1116, 1117, 1118, 1119, 1120]
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/MaterializedViewRewriter.java 78 78 100.00% []
🔵 com/starrocks/sql/optimizer/rewrite/scalar/MvNormalizePredicateRule.java 8 8 100.00% []
🔵 com/starrocks/sql/optimizer/MvPlanContextBuilder.java 4 4 100.00% []
🔵 com/starrocks/sql/optimizer/rule/mv/JoinDeriveContext.java 4 4 100.00% []

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Nov 2, 2023
@ABingHuang
[BugFix] Fix full outer join rewrite and nested mv refresh bug (StarR…
8dbf010 
…ocks#34071)

For rewrite:
1. fix join derivibility rewrite bug for multi joins query
2. fix equivalence class construction bugs to exclude outer join on predicate,
which should be rewritten by ReplaceColumnRefRewriter
3. optimize predicate normalization to process column name's case
4. set mv plan timeout to new_planner_optimize_timeout

For refresh:
1. fix refresh on nested mv bug to process date format like %Y%m%d
2. set strict mode to false for mv refresh

Signed-off-by: ABingHuang <codekhuang@163.com>
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Nov 3, 2023
@ABingHuang
[BugFix] Fix full outer join rewrite and nested mv refresh bug (StarR…
1b9a248 
…ocks#34071)

For rewrite:
1. fix join derivibility rewrite bug for multi joins query
2. fix equivalence class construction bugs to exclude outer join on predicate,
which should be rewritten by ReplaceColumnRefRewriter
3. optimize predicate normalization to process column name's case
4. set mv plan timeout to new_planner_optimize_timeout

For refresh:
1. fix refresh on nested mv bug to process date format like %Y%m%d
2. set strict mode to false for mv refresh

Signed-off-by: ABingHuang <codekhuang@163.com>
@ABingHuang ABingHuang changed the title [BugFix] Fix full outer join rewrite and nested mv refresh bug [BugFix] Fix full outer join rewrite and nested mv refresh bug for 3.1-mv Nov 3, 2023
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Nov 3, 2023
@ABingHuang
[BugFix] Fix full outer join rewrite and nested mv refresh bug (StarR…
5d3036c 
…ocks#34071)

For rewrite:
1. fix join derivibility rewrite bug for multi joins query
2. fix equivalence class construction bugs to exclude outer join on predicate,
which should be rewritten by ReplaceColumnRefRewriter
3. optimize predicate normalization to process column name's case
4. set mv plan timeout to new_planner_optimize_timeout

For refresh:
1. fix refresh on nested mv bug to process date format like %Y%m%d
2. set strict mode to false for mv refresh

Signed-off-by: ABingHuang <codekhuang@163.com>
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Nov 3, 2023
@ABingHuang
[BugFix] Fix full outer join rewrite and nested mv refresh bug (StarR…
83d6fc7 
…ocks#34071)

For rewrite:
1. fix join derivibility rewrite bug for multi joins query
2. fix equivalence class construction bugs to exclude outer join on predicate,
which should be rewritten by ReplaceColumnRefRewriter
3. optimize predicate normalization to process column name's case
4. set mv plan timeout to new_planner_optimize_timeout

For refresh:
1. fix refresh on nested mv bug to process date format like %Y%m%d
2. set strict mode to false for mv refresh

Signed-off-by: ABingHuang <codekhuang@163.com>
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Nov 3, 2023
@ABingHuang
[BugFix] Fix full outer join rewrite and nested mv refresh bug (StarR…
4758e41 
…ocks#34071)

For rewrite:
1. fix join derivibility rewrite bug for multi joins query
2. fix equivalence class construction bugs to exclude outer join on predicate,
which should be rewritten by ReplaceColumnRefRewriter
3. optimize predicate normalization to process column name's case
4. set mv plan timeout to new_planner_optimize_timeout

For refresh:
1. fix refresh on nested mv bug to process date format like %Y%m%d
2. set strict mode to false for mv refresh

Signed-off-by: ABingHuang <codekhuang@163.com>
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Nov 3, 2023
@ABingHuang
[BugFix] Fix full outer join rewrite and nested mv refresh bug (StarR…
2ed4135 
…ocks#34071)

For rewrite:
1. fix join derivibility rewrite bug for multi joins query
2. fix equivalence class construction bugs to exclude outer join on predicate,
which should be rewritten by ReplaceColumnRefRewriter
3. optimize predicate normalization to process column name's case
4. set mv plan timeout to new_planner_optimize_timeout

For refresh:
1. fix refresh on nested mv bug to process date format like %Y%m%d
2. set strict mode to false for mv refresh

Signed-off-by: ABingHuang <codekhuang@163.com>
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Nov 6, 2023
@ABingHuang
[BugFix] Fix full outer join rewrite and nested mv refresh bug (StarR…
21aca1c 
…ocks#34071)

For rewrite:
1. fix join derivibility rewrite bug for multi joins query
2. fix equivalence class construction bugs to exclude outer join on predicate,
which should be rewritten by ReplaceColumnRefRewriter
3. optimize predicate normalization to process column name's case
4. set mv plan timeout to new_planner_optimize_timeout

For refresh:
1. fix refresh on nested mv bug to process date format like %Y%m%d
2. set strict mode to false for mv refresh

Signed-off-by: ABingHuang <codekhuang@163.com>
ABingHuang added a commit that referenced this pull request Nov 6, 2023
@ABingHuang
[BugFix] Fix full outer join rewrite and nested mv refresh bug (#34071)…
ba601ba 
… (#34203)

For rewrite:
1. fix join derivibility rewrite bug for multi joins query
2. fix equivalence class construction bugs to exclude outer join on predicate, which should be rewritten by ReplaceColumnRefRewriter
3. optimize predicate normalization to process column name's case
4. set mv plan timeout to new_planner_optimize_timeout

For refresh:
1. fix refresh on nested mv bug to process date format like %Y%m%d

Signed-off-by: ABingHuang <codekhuang@163.com>
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Nov 9, 2023
@ABingHuang
[BugFix] Fix full outer join rewrite and nested mv refresh bug (StarR…
75ab92a 
…ocks#34071)

For rewrite:
1. fix join derivibility rewrite bug for multi joins query
2. fix equivalence class construction bugs to exclude outer join on predicate,
which should be rewritten by ReplaceColumnRefRewriter
3. optimize predicate normalization to process column name's case
4. set mv plan timeout to new_planner_optimize_timeout

For refresh:
1. fix refresh on nested mv bug to process date format like %Y%m%d
2. set strict mode to false for mv refresh

Signed-off-by: ABingHuang <codekhuang@163.com>
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Nov 9, 2023
@ABingHuang
[BugFix] Fix full outer join rewrite and nested mv refresh bug (StarR…
edeb0c5 
…ocks#34071)

For rewrite:
1. fix join derivibility rewrite bug for multi joins query
2. fix equivalence class construction bugs to exclude outer join on predicate,
which should be rewritten by ReplaceColumnRefRewriter
3. optimize predicate normalization to process column name's case
4. set mv plan timeout to new_planner_optimize_timeout

For refresh:
1. fix refresh on nested mv bug to process date format like %Y%m%d
2. set strict mode to false for mv refresh

Signed-off-by: ABingHuang <codekhuang@163.com>
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Nov 9, 2023
@ABingHuang
[BugFix] Fix full outer join rewrite and nested mv refresh bug (StarR…
5381358 
…ocks#34071)

For rewrite:
1. fix join derivibility rewrite bug for multi joins query
2. fix equivalence class construction bugs to exclude outer join on predicate,
which should be rewritten by ReplaceColumnRefRewriter
3. optimize predicate normalization to process column name's case
4. set mv plan timeout to new_planner_optimize_timeout

For refresh:
1. fix refresh on nested mv bug to process date format like %Y%m%d
2. set strict mode to false for mv refresh

Signed-off-by: ABingHuang <codekhuang@163.com>
LiShuMing pushed a commit that referenced this pull request Nov 9, 2023
@ABingHuang
[BugFix] Fix full outer join rewrite and nested mv refresh bug for 3.2(…
c94752c 
…#34071) (#34302)
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Nov 9, 2023
@ABingHuang
[BugFix] Fix full outer join rewrite and nested mv refresh bug (StarR…
1fbe6eb 
…ocks#34071)

For rewrite:
1. fix join derivibility rewrite bug for multi joins query
2. fix equivalence class construction bugs to exclude outer join on predicate,
which should be rewritten by ReplaceColumnRefRewriter
3. optimize predicate normalization to process column name's case
4. set mv plan timeout to new_planner_optimize_timeout

For refresh:
1. fix refresh on nested mv bug to process date format like %Y%m%d
2. set strict mode to false for mv refresh

Signed-off-by: ABingHuang <codekhuang@163.com>
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Nov 13, 2023
@ABingHuang
[BugFix] Fix full outer join rewrite and nested mv refresh bug (StarR…
ed87e83 
…ocks#34071)

For rewrite:
1. fix join derivibility rewrite bug for multi joins query
2. fix equivalence class construction bugs to exclude outer join on predicate,
which should be rewritten by ReplaceColumnRefRewriter
3. optimize predicate normalization to process column name's case
4. set mv plan timeout to new_planner_optimize_timeout

For refresh:
1. fix refresh on nested mv bug to process date format like %Y%m%d
2. set strict mode to false for mv refresh

Signed-off-by: ABingHuang <codekhuang@163.com>
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Nov 14, 2023
@ABingHuang
[BugFix] Fix full outer join rewrite and nested mv refresh bug (StarR…
f9fc770 
…ocks#34071)

For rewrite:
1. fix join derivibility rewrite bug for multi joins query
2. fix equivalence class construction bugs to exclude outer join on predicate,
which should be rewritten by ReplaceColumnRefRewriter
3. optimize predicate normalization to process column name's case
4. set mv plan timeout to new_planner_optimize_timeout

For refresh:
1. fix refresh on nested mv bug to process date format like %Y%m%d
2. set strict mode to false for mv refresh

Signed-off-by: ABingHuang <codekhuang@163.com>
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Nov 14, 2023
@ABingHuang
[BugFix] Fix full outer join rewrite and nested mv refresh bug (StarR…
806d300 
…ocks#34071)

For rewrite:
1. fix join derivibility rewrite bug for multi joins query
2. fix equivalence class construction bugs to exclude outer join on predicate,
which should be rewritten by ReplaceColumnRefRewriter
3. optimize predicate normalization to process column name's case
4. set mv plan timeout to new_planner_optimize_timeout

For refresh:
1. fix refresh on nested mv bug to process date format like %Y%m%d
2. set strict mode to false for mv refresh

Signed-off-by: ABingHuang <codekhuang@163.com>
ABingHuang added a commit that referenced this pull request Nov 14, 2023
@ABingHuang
[BugFix] Fix full outer join rewrite and nested mv refresh bug for main(
28ca296 
#34071) (#34299)

For rewrite:
1. fix join derivibility rewrite bug for multi joins query
2. fix equivalence class construction bugs to exclude outer join on predicate, which should be rewritten by ReplaceColumnRefRewriter
3. optimize predicate normalization to process column name's case
4. set mv plan timeout to new_planner_optimize_timeout

For refresh:
1. fix refresh on nested mv bug to process date format like %Y%m%d
2. set strict mode to false for mv refresh

Signed-off-by: ABingHuang <codekhuang@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiShuMing LiShuMing LiShuMing approved these changes

Assignees

@ABingHuang ABingHuang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ABingHuang @LiShuMing