-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]Support array_contains_seq functions like trino contains_sequence and ck hasSubstr function #33929
Merged
Merged
[Feature]Support array_contains_seq functions like trino contains_sequence and ck hasSubstr function #33929
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
aa015a8
support array_contains_seq functions like trino contains_sequence and…
leoyy0316 950bd8f
support array_contains_seq functions like trino contains_sequence and…
leoyy0316 e894887
support array_contains_seq functions like trino contains_sequence and…
leoyy0316 7bce46a
support array_contains_seq functions like trino contains_sequence and…
leoyy0316 4e564b3
support array_contains_seq functions like trino contains_sequence and…
leoyy0316 6fc6a75
support array_contains_seq functions like trino contains_sequence and…
leoyy0316 972e8ed
support array_contains_seq functions like trino contains_sequence and…
leoyy0316 c574a79
support array_contains_seq functions like trino contains_sequence and…
leoyy0316 5046ff4
support array_contains_seq functions like trino contains_sequence and…
leoyy0316 37bcfa6
support array_contains_seq functions like trino contains_sequence and…
leoyy0316 478c2de
support array_contains_seq functions like trino contains_sequence and…
leoyy0316 1f73ee6
support array_contains_seq functions like trino contains_sequence and…
leoyy0316 3bdd409
support array_contains_seq functions like trino contains_sequence and…
leoyy0316 16d3f0c
support array_contains_seq functions like trino contains_sequence and…
leoyy0316 efead1a
support array_contains_seq functions like trino contains_sequence and…
leoyy0316 d7b8ace
support array_contains_seq functions like trino contains_sequence and…
leoyy0316 a3724c8
support array_contains_seq functions like trino contains_sequence and…
leoyy0316 6ed5253
support array_contains_seq functions like trino contains_sequence and…
leoyy0316 2bbaa0d
support array_contains_seq functions like trino contains_sequence and…
leoyy0316 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
support array_contains_seq functions like trino contains_sequence and…
… ck hasSubstr Signed-off-by: leoyy0316 <571684903@qq.com>
- Loading branch information
commit 6ed525384b83433987a1b454923ca0c05cf0fcf6
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -780,10 +780,6 @@ class ArrayHasImpl { | |
while (j < element_end) { | ||
int k = j; | ||
i = target_start; | ||
if (j <= element_end - (target_end - target_start)) { | ||
return false; | ||
} | ||
|
||
while (i < target_end) { | ||
bool null_target = false; | ||
if constexpr (NullableTarget) { | ||
|
@@ -819,6 +815,9 @@ class ArrayHasImpl { | |
if (i == target_end) { | ||
return true; | ||
} | ||
if ((element_end - j) < (target_end - target_start)) { | ||
return false; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if put here, it should be <=; prefer put this condition to the while() at L:780 |
||
j++; | ||
} | ||
return false; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
j <= element_end - (target_end - target_start), no need to loop if the left elements are less than target's elements