-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Make scan metrics not duplicated for tablet internal parallel #33579
Merged
satanson
merged 7 commits into
StarRocks:main
from
ZiheLiu:opt/main/tablet_internal_parallel_profile
Oct 26, 2023
Merged
[Enhancement] Make scan metrics not duplicated for tablet internal parallel #33579
satanson
merged 7 commits into
StarRocks:main
from
ZiheLiu:opt/main/tablet_internal_parallel_profile
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZiheLiu
force-pushed
the
opt/main/tablet_internal_parallel_profile
branch
from
October 25, 2023 07:26
d5f985a
to
547326e
Compare
ZiheLiu
force-pushed
the
opt/main/tablet_internal_parallel_profile
branch
from
October 25, 2023 08:28
547326e
to
964970f
Compare
liuyehcf
reviewed
Oct 25, 2023
fe/fe-core/src/main/java/com/starrocks/common/util/Counter.java
Outdated
Show resolved
Hide resolved
…rallel Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
ZiheLiu
force-pushed
the
opt/main/tablet_internal_parallel_profile
branch
from
October 25, 2023 09:35
643c013
to
ad3458d
Compare
liuyehcf
reviewed
Oct 25, 2023
Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
satanson
previously approved these changes
Oct 25, 2023
Kudos, SonarCloud Quality Gate passed! |
[FE Incremental Coverage Report]✅ pass : 21 / 21 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 114 / 125 (91.20%) file detail
|
satanson
approved these changes
Oct 26, 2023
liuyehcf
approved these changes
Oct 26, 2023
smartlxh
pushed a commit
to smartlxh/starrocks
that referenced
this pull request
Mar 15, 2024
…rallel (StarRocks#33579) Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
wxl24life
pushed a commit
to wxl24life/starrocks
that referenced
this pull request
Apr 22, 2024
…nternal parallel (StarRocks#33579) Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
smartlxh
pushed a commit
to smartlxh/starrocks
that referenced
this pull request
Oct 16, 2024
…nternal parallel (StarRocks#33579) Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
smartlxh
pushed a commit
to smartlxh/starrocks
that referenced
this pull request
Oct 16, 2024
…nternal parallel (StarRocks#33579) Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the tablet internal parallel strategy is triggered, the metrics
SegmentZoneMapFilterRows
andShortKeyFilterRows
in the profile are counted multiple times.SegmentZoneMapFilterRows
ShortKeyFilterRows
PhysicalSplitMorselQueue
, the reason for the duplicate count is that applying the rowid range occurs after applying the short key range. So, moving the application of the rowid range before the application of the short key range will resolve this issue.ShortKeyFilterRows
counted by the current 4 ChunkSources areShortKeyFilterRows
is counted asShortKeyFilterRows
is correct (What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: