[Enhancement] Add timeout for execution state report #31734
+7
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoluan2009
changed the title
Signed-off-by: Xuedong Luan <luanxuedong2009@gmail.com>
Signed-off-by: Xuedong Luan <luanxuedong2009@gmail.com>
leoluan2009
force-pushed
the
rpc-timeout
branch
from
383a5bc to
66e4b17
Compare
[FE Incremental Coverage Report]😍 pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]😍 pass : 0 / 0 (0%) |
gengjun-git
reviewed
Sep 26, 2023
| @@ -125,22 +125,13 @@ Status ExecStateReporter::report_exec_status(const TReportExecStatusParams& para | |||
| try { | |||
There was a problem hiding this comment.
You can use ThriftRpcHelper::rpc here.
gengjun-git
reviewed
Sep 26, 2023
| @@ -148,7 +148,7 @@ class ClientConnection { | |||
| public: | |||
| ClientConnection(ClientCache<T>* client_cache, TNetworkAddress address, Status* status) | |||
There was a problem hiding this comment.
Better not change the timeout here, if user want to specify the timeout param, use the other constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31624
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: