Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Wait only for remote global runtime filters #31260

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

ZiheLiu
Copy link
Contributor

@ZiheLiu ZiheLiu commented Sep 18, 2023

If a runtime filter is planner by FE and isn't generated in BE due to exceeding the threshold, the left scan operator will always wait unit runtime_filter_scan_wait_time timeout regardless the hash join build operator has been finished.

  • remote=false. the BE threshold is runtime_join_filter_push_down_limit. We could wait only for remote global RFs to solve this.
  • remote=true. the BE threshold is global_runtime_filter_build_max_size, which is also the threshold to judge whether plan RF in FE. Therefore, if the cardinality of the right table is accurate, this usually cannot happen.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
@ZiheLiu ZiheLiu force-pushed the opt/main/global_rf_wait branch from d39e67e to bf8246a Compare September 18, 2023 05:35
@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😞 fail : 0 / 2 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/exec/pipeline/pipeline_driver.h 0 2 00.00% [346, 347]

@kangkaisen kangkaisen enabled auto-merge (squash) September 18, 2023 10:49
@kangkaisen kangkaisen merged commit f175341 into StarRocks:main Sep 18, 2023
@ZiheLiu
Copy link
Contributor Author

ZiheLiu commented Sep 19, 2023

@mergify backport branch-3.1 branch-3.2

@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2023

backport branch-3.1 branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 19, 2023
Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
(cherry picked from commit f175341)
mergify bot pushed a commit that referenced this pull request Sep 19, 2023
Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
(cherry picked from commit f175341)
wanpengfei-git pushed a commit that referenced this pull request Sep 19, 2023
Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
(cherry picked from commit f175341)
wanpengfei-git pushed a commit that referenced this pull request Sep 19, 2023
Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
(cherry picked from commit f175341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants