-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Wait only for remote global runtime filters #31260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d39e67e
to
bf8246a
Compare
stdpain
approved these changes
Sep 18, 2023
[FE Incremental Coverage Report]😍 pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]😞 fail : 0 / 2 (00.00%) file detail
|
satanson
approved these changes
Sep 18, 2023
@mergify backport branch-3.1 branch-3.2 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
Signed-off-by: zihe.liu <ziheliu1024@gmail.com> (cherry picked from commit f175341)
mergify bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
Signed-off-by: zihe.liu <ziheliu1024@gmail.com> (cherry picked from commit f175341)
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 19, 2023
Signed-off-by: zihe.liu <ziheliu1024@gmail.com> (cherry picked from commit f175341)
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 19, 2023
Signed-off-by: zihe.liu <ziheliu1024@gmail.com> (cherry picked from commit f175341)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a runtime filter is planner by FE and isn't generated in BE due to exceeding the threshold, the left scan operator will always wait unit
runtime_filter_scan_wait_time
timeout regardless the hash join build operator has been finished.remote=false
. the BE threshold isruntime_join_filter_push_down_limit
. We could wait only for remote global RFs to solve this.remote=true
. the BE threshold isglobal_runtime_filter_build_max_size
, which is also the threshold to judge whether plan RF in FE. Therefore, if the cardinality of the right table is accurate, this usually cannot happen.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: