Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] spark/flink connector export data without using column pool #30855

Merged
merged 1 commit into from
Sep 13, 2023
Merged

[Enhancement] spark/flink connector export data without using column pool #30855

merged 1 commit into from
Sep 13, 2023

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented Sep 12, 2023 •
edited
Loading

Currently, when using SparkConnector to export data (especially in scenarios with many columns and multi concurrency), it takes up a lot of ColumnPool memory, but does not improve performance. The current ColumnPool release mechanism is to release periodically, which will cause other queries fail to obtain enough memory.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@trueeyu
spark/flink connector export data without using column pool
3ca23f0 
Signed-off-by: trueeyu <lxhhust350@qq.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@silverbullet233 silverbullet233 enabled auto-merge (squash) September 12, 2023 11:39
@silverbullet233 silverbullet233 merged commit f9c3c05 into StarRocks:main Sep 13, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Sep 13, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Sep 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 13, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Sep 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 13, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Sep 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 13, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Sep 13, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 13, 2023
@trueeyu @mergify
[Enhancement] spark/flink connector export data without using column …
64fec0b 
…pool (#30855)

Signed-off-by: trueeyu <lxhhust350@qq.com>
(cherry picked from commit f9c3c05)
@mergify mergify bot mentioned this pull request Sep 13, 2023
Closed
mergify bot pushed a commit that referenced this pull request Sep 13, 2023
@trueeyu @mergify
[Enhancement] spark/flink connector export data without using column …
b135f36 
…pool (#30855)

Signed-off-by: trueeyu <lxhhust350@qq.com>
(cherry picked from commit f9c3c05)
mergify bot pushed a commit that referenced this pull request Sep 13, 2023
@trueeyu @mergify
[Enhancement] spark/flink connector export data without using column …
7ab1905 
…pool (#30855)

Signed-off-by: trueeyu <lxhhust350@qq.com>
(cherry picked from commit f9c3c05)

# Conflicts:
#	be/src/runtime/fragment_mgr.cpp
This was referenced Sep 13, 2023
Closed
Closed
mergify bot pushed a commit that referenced this pull request Sep 13, 2023
@trueeyu @mergify
[Enhancement] spark/flink connector export data without using column …
7a4908e 
…pool (#30855)

Signed-off-by: trueeyu <lxhhust350@qq.com>
(cherry picked from commit f9c3c05)

# Conflicts:
#	be/src/connector/lake_connector.cpp
#	be/src/runtime/fragment_mgr.cpp
#	be/src/runtime/runtime_state.cpp
#	be/src/storage/chunk_helper.cpp
#	be/src/storage/chunk_helper.h
@mergify mergify bot mentioned this pull request Sep 13, 2023
Closed
@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 32 / 40 (80.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/common/util/AutoInferUtil.java 5 7 71.43% [22, 30]
🔵 com/starrocks/statistic/StatisticsMetaManager.java 27 33 81.82% [192, 193, 223, 224, 261, 262]

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😞 fail : 0 / 14 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/storage/chunk_helper.cpp 0 1 00.00% [276]
🔵 src/connector/lake_connector.cpp 0 2 00.00% [276, 277]
🔵 src/exec/pipeline/scan/olap_chunk_source.cpp 0 2 00.00% [343, 344]
🔵 src/runtime/runtime_state.cpp 0 6 00.00% [264, 265, 266, 269, 270, 272]
🔵 src/exec/olap_scan_node.cpp 0 2 00.00% [194, 691]
🔵 src/runtime/fragment_mgr.cpp 0 1 00.00% [911]

trueeyu added a commit to trueeyu/starrocks that referenced this pull request Sep 15, 2023
@trueeyu
[Enhancement] spark/flink connector export data without using column …
7fae691 
…pool (StarRocks#30855)

Signed-off-by: trueeyu <lxhhust350@qq.com>
trueeyu added a commit to trueeyu/starrocks that referenced this pull request Sep 15, 2023
@trueeyu
[Enhancement] spark/flink connector export data without using column …
01d089c 
…pool (StarRocks#30855)

Signed-off-by: trueeyu <lxhhust350@qq.com>
trueeyu added a commit to trueeyu/starrocks that referenced this pull request Sep 18, 2023
@trueeyu
[Enhancement] spark/flink connector export data without using column …
7b7e42c 
…pool (StarRocks#30855)

Signed-off-by: trueeyu <lxhhust350@qq.com>
trueeyu added a commit to trueeyu/starrocks that referenced this pull request Sep 18, 2023
@trueeyu
[Enhancement] spark/flink connector export data without using column …
0c654de 
…pool (StarRocks#30855)

Signed-off-by: trueeyu <lxhhust350@qq.com>
trueeyu added a commit to trueeyu/starrocks that referenced this pull request Sep 18, 2023
@trueeyu
[Enhancement] spark/flink connector export data without using column …
d486434 
…pool (StarRocks#30855)

Signed-off-by: trueeyu <lxhhust350@qq.com>
trueeyu added a commit to trueeyu/starrocks that referenced this pull request Sep 18, 2023
@trueeyu
[Enhancement] spark/flink connector export data without using column …
941302f 
…pool (StarRocks#30855)

Signed-off-by: trueeyu <lxhhust350@qq.com>
trueeyu added a commit to trueeyu/starrocks that referenced this pull request Sep 18, 2023
@trueeyu
[Enhancement] spark/flink connector export data without using column …
16bf1ef 
…pool (StarRocks#30855)

Signed-off-by: trueeyu <lxhhust350@qq.com>
wyb pushed a commit that referenced this pull request Sep 18, 2023
@trueeyu
[Enhancement] spark/flink connector export data without using column …
11cc1f9 
…pool (#30855) (#31200)

Signed-off-by: trueeyu <lxhhust350@qq.com>
wyb pushed a commit that referenced this pull request Sep 18, 2023
@trueeyu
[Enhancement] spark/flink connector export data without using column …
97f1924 
…pool (#30855) (#31287)

Signed-off-by: trueeyu <lxhhust350@qq.com>
wyb pushed a commit that referenced this pull request Sep 18, 2023
@trueeyu
[Enhancement] spark/flink connector export data without using column …
b3a366a 
…pool (#30855) (#31288)

Signed-off-by: trueeyu <lxhhust350@qq.com>
wyb pushed a commit that referenced this pull request Sep 18, 2023
@trueeyu
[Enhancement] spark/flink connector export data without using column …
b874ae9 
…pool (#30855) (#31292)

Signed-off-by: trueeyu <lxhhust350@qq.com>
wyb pushed a commit that referenced this pull request Sep 18, 2023
@trueeyu
[Enhancement] spark/flink connector export data without using column …
33a5b4a 
…pool (#30855) (#31201)

Signed-off-by: trueeyu <lxhhust350@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@silverbullet233 silverbullet233 silverbullet233 approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

@trueeyu trueeyu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trueeyu @wanpengfei-git @wyb @silverbullet233 @kangkaisen