[Tool] dockerfile enhancement #30736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove unused fe.conf be.conf from allin1 docker image /data/deploy/ directory (Fixes StarRocks#30523) * tail be/cn out and info log file if not running with LOG_CONSOLE=1 in case of expect shutdown, give chances of last words to console for debugging Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
[FE Incremental Coverage Report]😍 pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]😍 pass : 0 / 0 (0%) |
imay
approved these changes
Sep 11, 2023
sduzh
approved these changes
Sep 12, 2023
|
@Mergifyio backport branch-3.2 branch-3.1 branch-3.0 branch-2.5 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com> (cherry picked from commit 20b4833)
mergify bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com> (cherry picked from commit 20b4833)
mergify bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com> (cherry picked from commit 20b4833)
mergify bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com> (cherry picked from commit 20b4833)
yandongxiao
reviewed
Sep 12, 2023
| if [[ $ret -ne 0 && "x$LOG_CONSOLE" != "x1" ]] ; then | ||
| nol=50 | ||
| log_stderr "Last $nol lines of be.INFO ..." | ||
| tail -n 50 $STARROCKS_HOME/log/be.INFO |
There was a problem hiding this comment.
tail -n $nol $STARROCKS_HOME/log/be.INFO
| log_stderr "Last $nol lines of be.INFO ..." | ||
| tail -n 50 $STARROCKS_HOME/log/be.INFO | ||
| log_stderr "Last $nol lines of be.out ..." | ||
| tail -n 50 $STARROCKS_HOME/log/be.out |
There was a problem hiding this comment.
tail -n $nol $STARROCKS_HOME/log/be.out
| log_stderr "Last $nol lines of cn.INFO ..." | ||
| tail -n $nol $STARROCKS_HOME/log/cn.INFO | ||
| log_stderr "Last $nol lines of cn.out ..." | ||
| tail -n $nol $STARROCKS_HOME/log/cn.out |
There was a problem hiding this comment.
I checked a k8s env, and there is no $STARROCKS_HOME environment.
There was a problem hiding this comment.
it is set in entrypoint
wyb
pushed a commit
that referenced
this pull request
Sep 13, 2023
wyb
pushed a commit
that referenced
this pull request
Sep 13, 2023
wyb
pushed a commit
that referenced
this pull request
Sep 13, 2023
wyb
pushed a commit
that referenced
this pull request
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: