[BugFix] Fix some bug of light schema change #30485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoyli
previously approved these changes
Sep 8, 2023
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
sevev
force-pushed
the
fix_light_schema_change
branch
from
ea3f369 to
3770eb8
Compare
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
sevev
changed the title
decster
approved these changes
Sep 13, 2023
[FE Incremental Coverage Report]😍 pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]😍 pass : 2 / 2 (100.00%) file detail
|
chaoyli
approved these changes
Sep 13, 2023
|
@mergify backport branch-3.2 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
This pr fixes some bugs: This pr([Feature] Support light schema change of adding and dropping columns #26246) supports light schema change and we add tablet schema in rowset meta. But in the course of multiple conflict resolution, the associated logic is lost. In addition, this pr change the location num of tablet_schema in RowsetMetaPB for better compatibility. When we create a column iterator in segment, if we provide tablet schema in read options, we should use the given tablet schema in create column iterator. Signed-off-by: zhangqiang <qiangzh95@gmail.com> (cherry picked from commit 5e0649e)
sevev
added a commit
that referenced
this pull request
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes some bugs:
tablet_schemainRowsetMetaPBfor better compatibility.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: