Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Refine profile to support visualization refactor(2) #30381

Merged
merged 2 commits into from
Sep 7, 2023
Merged

[Enhancement] Refine profile to support visualization refactor(2) #30381

merged 2 commits into from
Sep 7, 2023

Conversation

liuyehcf
Copy link
Contributor

@liuyehcf liuyehcf commented Sep 4, 2023 •
edited by jaogoy
Loading

This pr is an continuation work of #29063, and the main objectives of this pr are:

  1. Remove core level profile
  2. Change spill metrics from profile hierarchy to counter hierarchy for better analysis.
  3. Fix the wrong calculation of output rows for Join Node in text-based profile analysis

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.1
    • 3.0
    • 2.5
    • 2.4

@github-actions github-actions bot added the 3.1 label Sep 4, 2023
@liuyehcf
[Enhancement] Refine profile to support visualization refactor(2)
7f62216 
Signed-off-by: liuyehcf <1559500551@qq.com>
@liuyehcf
update enum value
de9ab94 
Signed-off-by: liuyehcf <1559500551@qq.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 7 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell B 512 Code Smells

0.0% 0.0% Coverage
0.3% 0.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 4 / 5 (80.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/SessionVariable.java 2 3 66.67% [2550]
🔵 com/starrocks/sql/ExplainAnalyzer.java 2 2 100.00% []

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😍 pass : 25 / 26 (96.15%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/exec/pipeline/pipeline_builder.cpp 0 1 00.00% [247]
🔵 src/exec/spill/spiller.cpp 25 25 100.00% []

@liuyehcf liuyehcf merged commit 653ae3e into StarRocks:main Sep 7, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Sep 7, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 7, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 7, 2023
@liuyehcf @mergify
[Enhancement] Refine profile to support visualization refactor(2) (#3…
3ff3912 
…0381)

* [Enhancement] Refine profile to support visualization refactor(2)

Signed-off-by: liuyehcf <1559500551@qq.com>

* update enum value

Signed-off-by: liuyehcf <1559500551@qq.com>

---------

Signed-off-by: liuyehcf <1559500551@qq.com>
(cherry picked from commit 653ae3e)

# Conflicts:
#	be/src/exec/spill/spiller.cpp
#	be/src/exec/spill/spiller.h
#	fe/fe-core/src/main/java/com/starrocks/qe/scheduler/QueryRuntimeProfile.java
@mergify mergify bot mentioned this pull request Sep 7, 2023
Merged
liuyehcf added a commit that referenced this pull request Sep 7, 2023
@mergify @liuyehcf
[Enhancement] Refine profile to support visualization refactor(2) (ba…
a4caca0 
…ckport #30381) (#30587)

* [Enhancement] Refine profile to support visualization refactor(2) (#30381)

* [Enhancement] Refine profile to support visualization refactor(2)

Signed-off-by: liuyehcf <1559500551@qq.com>

* update enum value

Signed-off-by: liuyehcf <1559500551@qq.com>

---------

Signed-off-by: liuyehcf <1559500551@qq.com>
(cherry picked from commit 653ae3e)

# Conflicts:
#	be/src/exec/spill/spiller.cpp
#	be/src/exec/spill/spiller.h
#	fe/fe-core/src/main/java/com/starrocks/qe/scheduler/QueryRuntimeProfile.java

* Fix conflict

Signed-off-by: liuyehcf <1559500551@qq.com>

* update 1

Signed-off-by: liuyehcf <1559500551@qq.com>

---------

Signed-off-by: liuyehcf <1559500551@qq.com>
Co-authored-by: liuyehcf <1559500551@qq.com>
Seaven pushed a commit to Seaven/starrocks that referenced this pull request Sep 8, 2023
@liuyehcf @Seaven
[Enhancement] Refine profile to support visualization refactor(2) (St…
9032f8b 
…arRocks#30381)

* [Enhancement] Refine profile to support visualization refactor(2)

Signed-off-by: liuyehcf <1559500551@qq.com>

* update enum value

Signed-off-by: liuyehcf <1559500551@qq.com>

---------

Signed-off-by: liuyehcf <1559500551@qq.com>
This was referenced Sep 13, 2023
Merged
Merged
@liuyehcf liuyehcf mentioned this pull request Oct 9, 2023
Merged
22 tasks
@github-actions github-actions bot added the 3.1 label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverbullet233 silverbullet233 silverbullet233 approved these changes

@stdpain stdpain stdpain approved these changes

Assignees

@liuyehcf liuyehcf

Labels
3.1 backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liuyehcf @wanpengfei-git @silverbullet233 @stdpain