Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix global dict late materialize optimize ignore delete conditions #30156

Merged
merged 1 commit into from
Aug 30, 2023
Merged

[BugFix] Fix global dict late materialize optimize ignore delete conditions #30156

merged 1 commit into from
Aug 30, 2023

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Aug 30, 2023 •
edited
Loading

Fixes https://github.com/StarRocks/StarRocksTest/issues/3774

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.1
    • 3.0
    • 2.5
    • 2.4

@stdpain
[BugFix] Fix global dict late materialize optimize ignore delete cond…
2654213 
…itions

Signed-off-by: stdpain <drfeng08@gmail.com>
@stdpain stdpain enabled auto-merge (squash) August 30, 2023 11:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@stdpain stdpain merged commit 9badac0 into StarRocks:main Aug 30, 2023
@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😞 fail : 0 / 1 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/storage/rowset/dictcode_column_iterator.h 0 1 00.00% [116]

@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Aug 30, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Aug 30, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Aug 30, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

@stdpain
Copy link
Contributor Author

stdpain commented Aug 30, 2023

https://github.com/Mergifyio backport branch-2.3

@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2023 •
edited
Loading

backport branch-2.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 30, 2023
@stdpain @mergify
[BugFix] Fix global dict late materialize optimize ignore delete cond…
300f87c 
…itions (#30156)

Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 9badac0)
@mergify mergify bot mentioned this pull request Aug 30, 2023
Merged
mergify bot pushed a commit that referenced this pull request Aug 30, 2023
@stdpain @mergify
[BugFix] Fix global dict late materialize optimize ignore delete cond…
e25b311 
…itions (#30156)

Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 9badac0)
@mergify mergify bot mentioned this pull request Aug 30, 2023
Merged
mergify bot pushed a commit that referenced this pull request Aug 30, 2023
@stdpain @mergify
[BugFix] Fix global dict late materialize optimize ignore delete cond…
5ebaddb 
…itions (#30156)

Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 9badac0)
@mergify mergify bot mentioned this pull request Aug 30, 2023
Merged
mergify bot pushed a commit that referenced this pull request Aug 30, 2023
@stdpain @mergify
[BugFix] Fix global dict late materialize optimize ignore delete cond…
b9d0268 
…itions (#30156)

Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 9badac0)
@mergify mergify bot mentioned this pull request Aug 30, 2023
Merged
stdpain added a commit that referenced this pull request Aug 31, 2023
@mergify @stdpain
[BugFix] Fix global dict late materialize optimize ignore delete cond…
7e992ec 
…itions (#30156) (#30170)

Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 9badac0)

Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>
stdpain added a commit that referenced this pull request Aug 31, 2023
@mergify @stdpain
[BugFix] Fix global dict late materialize optimize ignore delete cond…
bfc9641 
…itions (#30156) (#30169)

Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 9badac0)

Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>
stdpain added a commit that referenced this pull request Aug 31, 2023
@mergify @stdpain
[BugFix] Fix global dict late materialize optimize ignore delete cond…
952276e 
…itions (#30156) (#30172)

Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 9badac0)

Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>
stdpain added a commit that referenced this pull request Sep 1, 2023
@mergify @stdpain
[BugFix] Fix global dict late materialize optimize ignore delete cond…
e2648f9 
…itions (#30156) (#30171)

Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 9badac0)

Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>
Jay-ju pushed a commit to Jay-ju/starrocks that referenced this pull request Sep 7, 2023
@stdpain @Jay-ju
[BugFix] Fix global dict late materialize optimize ignore delete cond…
7467bfc 
…itions (StarRocks#30156)

Signed-off-by: stdpain <drfeng08@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverbullet233 silverbullet233 silverbullet233 approved these changes

@Seaven Seaven Seaven approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

@stdpain stdpain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stdpain @wanpengfei-git @silverbullet233 @Seaven @kangkaisen