Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix wrong state of 'is_result_sink' of query context #30098

Merged
merged 3 commits into from
Aug 30, 2023
Merged

[BugFix] Fix wrong state of 'is_result_sink' of query context #30098

merged 3 commits into from
Aug 30, 2023

Conversation

liuyehcf
Copy link
Contributor

@liuyehcf liuyehcf commented Aug 29, 2023 •
edited
Loading

Introduced by #29901

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.1
    • 3.0
    • 2.5
    • 2.4

@liuyehcf
[BugFix] Fix wrong state of 'is_result_sink' of query context
49171e9 
Signed-off-by: liuyehcf <1559500551@qq.com>
@liuyehcf
update 1
b6ba3ca 
Signed-off-by: liuyehcf <1559500551@qq.com>
trueeyu
trueeyu previously approved these changes Aug 29, 2023
View reviewed changes
@liuyehcf
update 2
e9d3e65 
Signed-off-by: liuyehcf <1559500551@qq.com>
@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😞 fail : 0 / 7 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/exec/pipeline/query_context.cpp 0 2 00.00% [179, 200]
🔵 src/exec/pipeline/fragment_executor.cpp 0 4 00.00% [542, 543, 544, 545]
🔵 src/exec/pipeline/query_context.h 0 1 00.00% [176]

@kangkaisen kangkaisen merged commit 8047e5d into StarRocks:main Aug 30, 2023
@liuyehcf
Copy link
Contributor Author

@Mergifyio backport branch-2.5

@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

@liuyehcf
Copy link
Contributor Author

@Mergifyio backport branch-3.0

@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify mergify bot mentioned this pull request Aug 31, 2023
Merged
mergify bot pushed a commit that referenced this pull request Aug 31, 2023
@liuyehcf @mergify
[BugFix] Fix wrong state of 'is_result_sink' of query context (#30098)
d05d204 
---------

Signed-off-by: liuyehcf <1559500551@qq.com>
(cherry picked from commit 8047e5d)
mergify bot pushed a commit that referenced this pull request Aug 31, 2023
@liuyehcf @mergify
[BugFix] Fix wrong state of 'is_result_sink' of query context (#30098)
07e444d 
---------

Signed-off-by: liuyehcf <1559500551@qq.com>
(cherry picked from commit 8047e5d)
@mergify mergify bot mentioned this pull request Aug 31, 2023
Merged
@liuyehcf
Copy link
Contributor Author

@Mergifyio backport branch-3.1

@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 31, 2023
@liuyehcf @mergify
[BugFix] Fix wrong state of 'is_result_sink' of query context (#30098)
b567b05 
---------

Signed-off-by: liuyehcf <1559500551@qq.com>
(cherry picked from commit 8047e5d)
@mergify mergify bot mentioned this pull request Aug 31, 2023
Merged
liuyehcf added a commit that referenced this pull request Aug 31, 2023
@mergify @liuyehcf
[BugFix] Fix wrong state of 'is_result_sink' of query context (backport
7ad365e 
#30098) (#30201)

* [BugFix] Fix wrong state of 'is_result_sink' of query context (#30098)

---------

Signed-off-by: liuyehcf <1559500551@qq.com>
(cherry picked from commit 8047e5d)

* update 1

Signed-off-by: liuyehcf <1559500551@qq.com>

---------

Signed-off-by: liuyehcf <1559500551@qq.com>
Co-authored-by: liuyehcf <1559500551@qq.com>
liuyehcf added a commit that referenced this pull request Aug 31, 2023
@mergify @liuyehcf
[BugFix] Fix wrong state of 'is_result_sink' of query context (backport
271de21 
#30098) (#30202)

* [BugFix] Fix wrong state of 'is_result_sink' of query context (#30098)

---------

Signed-off-by: liuyehcf <1559500551@qq.com>
(cherry picked from commit 8047e5d)

* update 1

Signed-off-by: liuyehcf <1559500551@qq.com>

---------

Signed-off-by: liuyehcf <1559500551@qq.com>
Co-authored-by: liuyehcf <1559500551@qq.com>
trueeyu pushed a commit that referenced this pull request Aug 31, 2023
@mergify @liuyehcf
[BugFix] Fix wrong state of 'is_result_sink' of query context (backport
29d0f79 
#30098) (#30203)

* [BugFix] Fix wrong state of 'is_result_sink' of query context (#30098)

---------

Signed-off-by: liuyehcf <1559500551@qq.com>
(cherry picked from commit 8047e5d)

* update 1

Signed-off-by: liuyehcf <1559500551@qq.com>

---------

Signed-off-by: liuyehcf <1559500551@qq.com>
Co-authored-by: liuyehcf <1559500551@qq.com>
Jay-ju pushed a commit to Jay-ju/starrocks that referenced this pull request Sep 7, 2023
@liuyehcf @Jay-ju
[BugFix] Fix wrong state of 'is_result_sink' of query context (StarRo…
fff13b5 
…cks#30098)


---------

Signed-off-by: liuyehcf <1559500551@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangkaisen kangkaisen kangkaisen approved these changes

@trueeyu trueeyu trueeyu approved these changes

Assignees

@liuyehcf liuyehcf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liuyehcf @wanpengfei-git @kangkaisen @trueeyu @jaogoy