Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support the string fucntion TRANSLATE #29771

Merged
merged 9 commits into from
Aug 24, 2023
Merged

[Feature] Support the string fucntion TRANSLATE #29771

merged 9 commits into from
Aug 24, 2023

Conversation

ZiheLiu
Copy link
Contributor

@ZiheLiu ZiheLiu commented Aug 23, 2023 •
edited
Loading

Closes #22704.

Inspired by and will close #23611.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.1
    • 3.0
    • 2.5
    • 2.4

@ZiheLiu
[Feature] Support the string fucntion TRANSLATE
6c8046a 
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
@ZiheLiu ZiheLiu requested a review from a team as a code owner August 23, 2023 05:16
ZiheLiu added 2 commits August 23, 2023 13:21
@ZiheLiu
update comment
cae479e 
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
@ZiheLiu
add CHECK
0707839 
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
ZiheLiu added 2 commits August 23, 2023 15:43
@ZiheLiu
use byte array instead of ascii_map
fac4c39 
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
@ZiheLiu
fix
ec46417 
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
@ZiheLiu
use src_offsets.back()
a3f3ffc 
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
fzhedu
fzhedu previously approved these changes Aug 23, 2023
View reviewed changes
@ZiheLiu
fix
e0d8917 
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
ZiheLiu added 2 commits August 23, 2023 21:59
@ZiheLiu
add test
985e884 
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
@ZiheLiu
add test
e219850 
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😞 fail : 0 / 215 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/exprs/string_functions.cpp 0 196 00.00% [1075, 1077, 1089, 1090, 1091, 1093, 1094, 1096, 1097, 1098, 1099, 1101, 1102, 1103, 1104, 1105, 1106, 1109, 1110, 1111, 1112, 1116, 1118, 1119, 1120, 1121, 1123, 1124, 1139, 1142, 1143, 1144, 1145, 1146, 1147, 1148, 1149, 1151, 1154, 1155, 1157, 1158, 1161, 1172, 1174, 1175, 1176, 1177, 1178, 1179, 1180, 1184, 1187, 1188, 1189, 1192, 1193, 1196, 1197, 1198, 1200, 1202, 1203, 1205, 1206, 1208, 1210, 1213, 1214, 1215, 1216, 1218, 1233, 1235, 1236, 1238, 1239, 1240, 1241, 1243, 1244, 1245, 1248, 1249, 1250, 1251, 1253, 1254, 1256, 1257, 1258, 1259, 1260, 1261, 1264, 1266, 1282, 1284, 1285, 1287, 1288, 1289, 1290, 1292, 1293, 1294, 1297, 1298, 1302, 1303, 1304, 1305, 1307, 1308, 1309, 1311, 1312, 1313, 1315, 1316, 1317, 1319, 1320, 1322, 1323, 1324, 1325, 1326, 1328, 1329, 1333, 1334, 1336, 1349, 1350, 1352, 1353, 1354, 1356, 1357, 1358, 1359, 1361, 1362, 1363, 1366, 1367, 1368, 1369, 1370, 1371, 1373, 1374, 1375, 1376, 1378, 1379, 1380, 1381, 1382, 1383, 1386, 1387, 1388, 1390, 1391, 1392, 1394, 1395, 1396, 1398, 1399, 1400, 1402, 1403, 1405, 1406, 1407, 1408, 1409, 1410, 1412, 1413, 1418, 1419, 1421, 1424, 1425, 1427, 1428, 1429, 1430, 1431, 1433, 1436, 1439]
🔵 src/util/utf8_encoding.h 0 19 00.00% [35, 36, 37, 38, 40, 41, 47, 49, 50, 51, 52, 55, 58, 63, 66, 67, 68, 69, 71]

@fzhedu fzhedu enabled auto-merge August 24, 2023 09:22
@ZiheLiu ZiheLiu disabled auto-merge August 24, 2023 09:23
@ZiheLiu ZiheLiu merged commit c7ae662 into StarRocks:main Aug 24, 2023
@ZiheLiu ZiheLiu deleted the feat/main/translate branch August 24, 2023 09:25
@ZiheLiu
Copy link
Contributor Author

ZiheLiu commented Aug 25, 2023

@mergify backport branch-3.0 branch-3.1

@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2023 •
edited
Loading

backport branch-3.0 branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 25, 2023
@ZiheLiu @mergify
[Feature] Support the string fucntion TRANSLATE (#29771)
ddff24b 
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
(cherry picked from commit c7ae662)
@mergify mergify bot mentioned this pull request Aug 25, 2023
Merged
mergify bot pushed a commit that referenced this pull request Aug 25, 2023
@ZiheLiu @mergify
[Feature] Support the string fucntion TRANSLATE (#29771)
cf99aab 
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
(cherry picked from commit c7ae662)
@mergify mergify bot mentioned this pull request Aug 25, 2023
Merged
wanpengfei-git pushed a commit that referenced this pull request Aug 25, 2023
@ZiheLiu @wanpengfei-git
[Feature] Support the string fucntion TRANSLATE (#29771)
befc910 
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
(cherry picked from commit c7ae662)
wanpengfei-git pushed a commit that referenced this pull request Aug 25, 2023
@ZiheLiu @wanpengfei-git
[Feature] Support the string fucntion TRANSLATE (#29771)
3141e41 
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
(cherry picked from commit c7ae662)
Jay-ju pushed a commit to Jay-ju/starrocks that referenced this pull request Sep 7, 2023
@ZiheLiu @Jay-ju
[Feature] Support the string fucntion TRANSLATE (StarRocks#29771)
1d7a7d0 
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satanson satanson satanson approved these changes

@fzhedu fzhedu fzhedu approved these changes

@packy92 packy92 packy92 approved these changes

Assignees

@ZiheLiu ZiheLiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[function]translate
5 participants
@ZiheLiu @wanpengfei-git @satanson @fzhedu @packy92