Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Add agent task metrics #29707

Merged
merged 2 commits into from
Aug 25, 2023
Merged

[Enhancement] Add agent task metrics #29707

merged 2 commits into from
Aug 25, 2023

Conversation

gengjun-git
Copy link
Contributor

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.1
    • 3.0
    • 2.5
    • 2.4

@gengjun-git
Copy link
Contributor Author

@Mergifyio rebase

@gengjun-git
add
03b5710 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
@gengjun-git
add
4f73ba9 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2023

rebase

✅ Branch has been successfully rebased

@gengjun-git gengjun-git force-pushed the add_agent_task_metrics branch from 7fb0a54 to 4f73ba9 Compare August 24, 2023 07:45
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 5 / 5 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/metric/MetricRepo.java 5 5 100.00% []

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@gengjun-git gengjun-git enabled auto-merge (squash) August 24, 2023 12:10
@gengjun-git gengjun-git merged commit 90f88b9 into StarRocks:main Aug 25, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Aug 25, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Aug 25, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Aug 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 25, 2023
@gengjun-git @mergify
[Enhancement] Add agent task metrics (#29707)
291d23f 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
(cherry picked from commit 90f88b9)
@mergify mergify bot mentioned this pull request Aug 25, 2023
Merged
mergify bot pushed a commit that referenced this pull request Aug 25, 2023
@gengjun-git @mergify
[Enhancement] Add agent task metrics (#29707)
1a14070 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
(cherry picked from commit 90f88b9)
mergify bot pushed a commit that referenced this pull request Aug 25, 2023
@gengjun-git @mergify
[Enhancement] Add agent task metrics (#29707)
8a928e3 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
(cherry picked from commit 90f88b9)
@mergify mergify bot mentioned this pull request Aug 25, 2023
Merged
@mergify mergify bot mentioned this pull request Aug 25, 2023
Merged
imay pushed a commit that referenced this pull request Aug 25, 2023
@mergify @gengjun-git
[Enhancement] Add agent task metrics (#29707) (#29917)
89755ec 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
(cherry picked from commit 90f88b9)

Co-authored-by: gengjun-git <gengjun@starrocks.com>
gengjun-git added a commit that referenced this pull request Aug 28, 2023
@gengjun-git
[Enhancement] Add agent task metrics (#29707)
ad7d328 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
(cherry picked from commit 90f88b9)
gengjun-git added a commit that referenced this pull request Aug 28, 2023
@mergify @gengjun-git
[Enhancement] Add agent task metrics (#29707) (#29919)
2c5b304 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
(cherry picked from commit 90f88b9)

Co-authored-by: gengjun-git <gengjun@starrocks.com>
Jay-ju pushed a commit to Jay-ju/starrocks that referenced this pull request Sep 7, 2023
@gengjun-git @Jay-ju
[Enhancement] Add agent task metrics (StarRocks#29707)
05a2354 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
gengjun-git added a commit that referenced this pull request Sep 22, 2023
@mergify @gengjun-git
[Enhancement] Add agent task metrics (backport #29707) (#29918)
b9977af 
Co-authored-by: gengjun-git <gengjun@starrocks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduzh sduzh sduzh approved these changes

@Astralidea Astralidea Astralidea approved these changes

Assignees

@gengjun-git gengjun-git

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gengjun-git @wanpengfei-git @sduzh @Astralidea