Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] add nap_sleep() to handle sleep a large portion of time #29689

Merged
merged 1 commit into from
Aug 23, 2023
Merged

[Enhancement] add nap_sleep() to handle sleep a large portion of time #29689

merged 1 commit into from
Aug 23, 2023

Conversation

kevincai
Copy link
Contributor

  • respect AWS_EC2_METADATA_DISABLED if already set in env
  • BE binary can stop with 10 seconds with this change nap_sleep() change and also AWS_EC2_METADATA_DISABLED=true in non-ec2 env

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.1
    • 3.0
    • 2.5
    • 2.4

@kevincai
[Enhancement] add nap_sleep() to handle sleep a large portion of time
fccb4f7 
* respect AWS_EC2_METADATA_DISABLED if already set in env
* BE binary can stop with 10 seconds with this change nap_sleep() change
  and also AWS_EC2_METADATA_DISABLED=true in non-ec2 env

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😞 fail : 11 / 18 (61.11%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/agent/task_worker_pool.cpp 0 4 00.00% [604, 605, 745, 746]
🔵 src/common/daemon.cpp 0 2 00.00% [104, 188]
🔵 src/service/service_be/starrocks_be.cpp 0 1 00.00% [214]
🔵 src/runtime/routine_load/data_consumer_pool.cpp 1 1 100.00% []
🔵 src/runtime/stream_load/transaction_mgr.cpp 1 1 100.00% []
🔵 src/util/misc.cpp 5 5 100.00% []
🔵 src/runtime/profile_report_worker.cpp 1 1 100.00% []
🔵 src/runtime/result_buffer_mgr.cpp 1 1 100.00% []
🔵 src/runtime/broker_mgr.cpp 1 1 100.00% []
🔵 src/runtime/fragment_mgr.cpp 1 1 100.00% []

@sduzh sduzh self-requested a review August 23, 2023 03:01
@sduzh sduzh merged commit ef6c338 into StarRocks:main Aug 23, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.1

@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 23, 2023
@kevincai @mergify
[Enhancement] add nap_sleep() to handle sleep a large portion of time (…
d1c1761 
…#29689)

* respect AWS_EC2_METADATA_DISABLED if already set in env
* BE binary can stop with 10 seconds with this change nap_sleep() change
  and also AWS_EC2_METADATA_DISABLED=true in non-ec2 env

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit ef6c338)

# Conflicts:
#	be/src/common/daemon.cpp
#	be/src/service/service_be/starrocks_be.cpp
@mergify mergify bot mentioned this pull request Aug 23, 2023
Closed
mergify bot pushed a commit that referenced this pull request Aug 23, 2023
@kevincai @mergify
[Enhancement] add nap_sleep() to handle sleep a large portion of time (…
92098ae 
…#29689)

* respect AWS_EC2_METADATA_DISABLED if already set in env
* BE binary can stop with 10 seconds with this change nap_sleep() change
  and also AWS_EC2_METADATA_DISABLED=true in non-ec2 env

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit ef6c338)

# Conflicts:
#	be/src/common/daemon.cpp
#	be/src/service/service_be/starrocks_be.cpp
@mergify mergify bot mentioned this pull request Aug 23, 2023
Closed
kevincai added a commit to kevincai/starrocks that referenced this pull request Aug 23, 2023
@kevincai
[Enhancement] add nap_sleep() to handle sleep a large portion of time (…
a37d1b2 
…StarRocks#29689)

* respect AWS_EC2_METADATA_DISABLED if already set in env
* BE binary can stop with 10 seconds with this change nap_sleep() change
  and also AWS_EC2_METADATA_DISABLED=true in non-ec2 env

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit ef6c338)

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
kevincai added a commit to kevincai/starrocks that referenced this pull request Aug 23, 2023
@kevincai
[Enhancement] add nap_sleep() to handle sleep a large portion of time (…
266a043 
…StarRocks#29689)

* respect AWS_EC2_METADATA_DISABLED if already set in env
* BE binary can stop with 10 seconds with this change nap_sleep() change
  and also AWS_EC2_METADATA_DISABLED=true in non-ec2 env

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit ef6c338)

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
@kevincai
Copy link
Contributor Author

manual backport to branch-3.1 at #29773

kevincai added a commit to kevincai/starrocks that referenced this pull request Aug 23, 2023
@kevincai
[Enhancement] add nap_sleep() to handle sleep a large portion of time (…
0085a28 
…StarRocks#29689)

* respect AWS_EC2_METADATA_DISABLED if already set in env
* BE binary can stop with 10 seconds with this change nap_sleep() change
  and also AWS_EC2_METADATA_DISABLED=true in non-ec2 env

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit ef6c338)

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
@kevincai
Copy link
Contributor Author

manual backport to branch-3.0 at #29775

@kevincai kevincai deleted the nap_sleep_wakeup-asap branch August 23, 2023 09:00
imay pushed a commit that referenced this pull request Aug 23, 2023
@kevincai
[Enhancement] add nap_sleep() to handle sleep a large portion of time (…
540eb1f 
…#29689) (#29773)

* respect AWS_EC2_METADATA_DISABLED if already set in env
* BE binary can stop with 10 seconds with this change nap_sleep() change
  and also AWS_EC2_METADATA_DISABLED=true in non-ec2 env


(cherry picked from commit ef6c338)

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
imay pushed a commit that referenced this pull request Aug 23, 2023
@kevincai
[Enhancement] add nap_sleep() to handle sleep a large portion of time (…
d77ce73 
…#29689) (#29775)

* respect AWS_EC2_METADATA_DISABLED if already set in env
* BE binary can stop with 10 seconds with this change nap_sleep() change
  and also AWS_EC2_METADATA_DISABLED=true in non-ec2 env


(cherry picked from commit ef6c338)

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
kangkaisen pushed a commit that referenced this pull request Aug 28, 2023
@kevincai @kangkaisen
[Enhancement] add nap_sleep() to handle sleep a large portion of time (…
d25cd34 
…#29689) (#29773)

* respect AWS_EC2_METADATA_DISABLED if already set in env
* BE binary can stop with 10 seconds with this change nap_sleep() change
  and also AWS_EC2_METADATA_DISABLED=true in non-ec2 env


(cherry picked from commit ef6c338)

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
Jay-ju pushed a commit to Jay-ju/starrocks that referenced this pull request Sep 7, 2023
@kevincai @Jay-ju
[Enhancement] add nap_sleep() to handle sleep a large portion of time (…
d84bc7d 
…StarRocks#29689)

* respect AWS_EC2_METADATA_DISABLED if already set in env
* BE binary can stop with 10 seconds with this change nap_sleep() change
  and also AWS_EC2_METADATA_DISABLED=true in non-ec2 env

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduzh sduzh sduzh approved these changes

@trueeyu trueeyu trueeyu approved these changes

Assignees

@kevincai kevincai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevincai @wanpengfei-git @sduzh @trueeyu