Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Byte pass through not effect when using fqdn in k8s environment #29676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wxl24life
Copy link
Contributor

@wxl24life wxl24life commented Aug 22, 2023

Why I'm doing:

What I'm doing:

Fixes #29677

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@wxl24life wxl24life force-pushed the fix_passthrough_k8s branch from 5bc0e61 to 2d6d2aa Compare August 22, 2023 07:11
@miomiocat miomiocat enabled auto-merge (squash) September 17, 2023 09:47
auto-merge was automatically disabled February 19, 2024 12:55

Head branch was pushed to by a user without write access

@wxl24life wxl24life requested a review from a team as a code owner February 19, 2024 12:55
@github-actions github-actions bot deleted a comment from wanpengfei-git Feb 19, 2024
@github-actions github-actions bot deleted a comment from wanpengfei-git Feb 19, 2024
Copy link

[BE Incremental Coverage Report]

fail : 3 / 6 (50.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/pipeline/exchange/exchange_sink_operator.cpp 3 6 50.00% [176, 177, 178]

@kevincai
Copy link
Contributor

@Mergifyio rebase

Copy link
Contributor

mergify bot commented Jun 28, 2024

rebase

✅ Branch has been successfully rebased

Signed-off-by: drake_wang <wxl250059@alibaba-inc.com>
@wxl24life wxl24life force-pushed the fix_passthrough_k8s branch from d7a165b to 079f6e5 Compare July 3, 2024 03:04
Copy link

github-actions bot commented Jul 3, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In k8s environment, Exchange Operator's pass through feature will not take effect
5 participants