Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] reduce chunk buffer size in streaming aggregate #28962

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Aug 9, 2023

  1. add memory limit for streaming agg
  2. add profile for streaming agg
    eg:
             - ChunkBufferPeakMem: 48.00 MB
             - ChunkBufferPeakSize: 1.024K (1024)

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.1
    • 3.0
    • 2.5
    • 2.4

Signed-off-by: stdpain <drfeng08@gmail.com>
@stdpain stdpain enabled auto-merge (squash) August 9, 2023 11:58
@mergify mergify bot assigned stdpain Aug 9, 2023
stdpain added 2 commits August 9, 2023 20:35
Signed-off-by: stdpain <drfeng08@gmail.com>
Signed-off-by: stdpain <drfeng08@gmail.com>
@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 0 / 0 (0%)

@stdpain stdpain merged commit 357a625 into StarRocks:main Aug 10, 2023
Seaven pushed a commit to Seaven/starrocks that referenced this pull request Aug 16, 2023
…cks#28962)

Signed-off-by: stdpain <drfeng08@gmail.com>
Signed-off-by: Seaven <seaven_7@qq.com>
silverbullet233 added a commit to silverbullet233/starrocks that referenced this pull request Aug 29, 2023
silverbullet233 added a commit to silverbullet233/starrocks that referenced this pull request Aug 29, 2023
Jay-ju pushed a commit to Jay-ju/starrocks that referenced this pull request Sep 7, 2023
stdpain added a commit to stdpain/starrocks-2 that referenced this pull request Nov 2, 2023
…cks#28962)

Signed-off-by: stdpain <drfeng08@gmail.com>

Signed-off-by: stdpain <34912776+stdpain@users.noreply.github.com>
stdpain added a commit that referenced this pull request Nov 7, 2023
Signed-off-by: stdpain <drfeng08@gmail.com>

Signed-off-by: stdpain <34912776+stdpain@users.noreply.github.com>
mergify bot pushed a commit that referenced this pull request Nov 16, 2023
Signed-off-by: stdpain <drfeng08@gmail.com>

Signed-off-by: stdpain <34912776+stdpain@users.noreply.github.com>
(cherry picked from commit 762bdfa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants