Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Optimize segment iterator initialization #28722

Merged
merged 1 commit into from
Aug 8, 2023
Merged

[Enhancement] Optimize segment iterator initialization #28722

merged 1 commit into from
Aug 8, 2023

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Aug 7, 2023 •
edited
Loading

  1. if the scan range is already empty, the other indexes will not be used to filter.
  2. load bitmap index when it is used.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.1
    • 3.0
    • 2.5
    • 2.4

@wyb
[Enhancement] Optimize segment iterator initialization
3d4c939 
1. when the scan range is already empty, the other indexes will not be used to filter.
2. load bitmap index when it is used.

Signed-off-by: wyb <wybb86@gmail.com>
@mergify mergify bot assigned wyb Aug 7, 2023
@github-actions github-actions bot added the 3.1 label Aug 7, 2023
@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 0 / 0 (0%)

@wyb wyb requested review from stdpain and sduzh August 7, 2023 12:12
@sduzh sduzh merged commit 8e80483 into StarRocks:main Aug 8, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Aug 8, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 8, 2023
@wyb @mergify
[Enhancement] Optimize segment iterator initialization (#28722)
a976e57 
1. if the scan range is already empty, the other indexes will not be
used to filter.
2. load bitmap index when it is used.

Signed-off-by: wyb <wybb86@gmail.com>
(cherry picked from commit 8e80483)
@mergify mergify bot mentioned this pull request Aug 8, 2023
Merged
wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2023
@wyb @wanpengfei-git
[Enhancement] Optimize segment iterator initialization (#28722)
c60ffbc 
1. if the scan range is already empty, the other indexes will not be
used to filter.
2. load bitmap index when it is used.

Signed-off-by: wyb <wybb86@gmail.com>
(cherry picked from commit 8e80483)
Jay-ju pushed a commit to Jay-ju/starrocks that referenced this pull request Sep 7, 2023
@wyb @Jay-ju
[Enhancement] Optimize segment iterator initialization (StarRocks#28722)
421e7ee 
1. if the scan range is already empty, the other indexes will not be
used to filter.
2. load bitmap index when it is used.

Signed-off-by: wyb <wybb86@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduzh sduzh sduzh approved these changes

@stdpain stdpain stdpain approved these changes

Assignees

@wyb wyb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wyb @wanpengfei-git @sduzh @stdpain