Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support to_tera_date/to_tera_timestamp #28509

Merged
merged 3 commits into from
Sep 13, 2023
Merged

[Feature] Support to_tera_date/to_tera_timestamp #28509

merged 3 commits into from
Sep 13, 2023

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Aug 2, 2023 •
edited by wanpengfei-git
Loading

Fixes #issue

Support to_tera_date /to_tera_timestamp function to be compatible with trino : https://trino.io/docs/current/functions/list-by-topic.html?highlight=teradata#teradata

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.1
    • 3.0
    • 2.5
    • 2.4

@LiShuMing LiShuMing requested a review from a team as a code owner August 2, 2023 10:06
@wanpengfei-git wanpengfei-git added the documentation Improvements or additions to documentation label Aug 2, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 0 / 0 (0%)

@LiShuMing
Support to_tera_date/to_tera_timestamp functions
43b9178 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
@LiShuMing
fix bugs
539b033 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
@LiShuMing LiShuMing changed the title [Feature] Support to_date/to_timestamp [Feature] Support to_tera_date/to_tera_timestamp Sep 13, 2023
@LiShuMing
fix bugs
36dde17 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@kangkaisen kangkaisen enabled auto-merge (squash) September 13, 2023 05:54
@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😍 pass : 194 / 241 (80.50%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/runtime/datetime_value.cpp 126 161 78.26% [1954, 1964, 1970, 1980, 1988, 1996, 2007, 2010, 2016, 2020, 2030, 2033, 2039, 2043, 2058, 2066, 2077, 2084, 2090, 2097, 2108, 2109, 2110, 2112, 2113, 2115, 2116, 2117, 2118, 2119, 2127, 2134, 2138, 2139, 2154]
🔵 src/exprs/time_functions.cpp 62 74 83.78% [656, 660, 668, 690, 695, 701, 717, 721, 729, 753, 758, 764]
🔵 src/runtime/datetime_value.h 6 6 100.00% []

@kangkaisen kangkaisen disabled auto-merge September 13, 2023 10:57
@kangkaisen kangkaisen merged commit c78694a into StarRocks:main Sep 13, 2023
@jaogoy jaogoy requested a review from wangsimo0 September 13, 2023 12:03
LiShuMing added a commit to LiShuMing/starrocks that referenced this pull request Sep 26, 2023
@LiShuMing
[Feature] Support to_tera_date/to_tera_timestamp (StarRocks#28509)
0bfde08 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
LiShuMing added a commit to LiShuMing/starrocks that referenced this pull request Sep 26, 2023
@LiShuMing
[Feature] Support to_tera_date/to_tera_timestamp (StarRocks#28509)
7b8aab2 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
kangkaisen pushed a commit that referenced this pull request Sep 26, 2023
@LiShuMing
[Feature] Support to_tera_date/to_tera_timestamp (#28509) (#31766)
2e7614a 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
kangkaisen pushed a commit that referenced this pull request Sep 26, 2023
@LiShuMing
[Feature] Support to_tera_date/to_tera_timestamp (#28509) (#31767)
3bce73a 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
@LiShuMing
Copy link
Contributor Author

@mergfyio backport branch-3.2

@LiShuMing
Copy link
Contributor Author

@Mergifyio backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 13, 2023
@LiShuMing @mergify
[Feature] Support to_tera_date/to_tera_timestamp (#28509)
b5c7e0d 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit c78694a)

# Conflicts:
#	docs/en/sql-reference/sql-functions/date-time-functions/to_tera_date.md
#	docs/en/sql-reference/sql-functions/date-time-functions/to_tera_timestamp.md
@mergify mergify bot mentioned this pull request Dec 13, 2023
Closed
LiShuMing added a commit to LiShuMing/starrocks that referenced this pull request Dec 13, 2023
@LiShuMing
[Feature] Support to_tera_date/to_tera_timestamp (StarRocks#28509)
db011ae 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
LiShuMing added a commit to LiShuMing/starrocks that referenced this pull request Dec 13, 2023
@LiShuMing
[Feature] Support to_tera_date/to_tera_timestamp (StarRocks#28509)
8f61c44 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
kangkaisen pushed a commit that referenced this pull request Dec 13, 2023
@LiShuMing
[Feature] Support to_tera_date/to_tera_timestamp (backport #28509) (#…
8d3eae4 
…36910)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seaven Seaven Seaven left review comments

@kangkaisen kangkaisen kangkaisen approved these changes

@murphyatwork murphyatwork murphyatwork approved these changes

@wangsimo0 wangsimo0 Awaiting requested review from wangsimo0

Assignees

@LiShuMing LiShuMing

Labels
behavior_changed documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LiShuMing @wanpengfei-git @Seaven @kangkaisen @murphyatwork