[BugFix] fix and refactor logical of inference bucket number #26726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoyli
reviewed
Jul 7, 2023
| if (base.getTable().isNativeTableOrMaterializedView()) { | ||
| OlapTable olapTable = (OlapTable) base.getTable(); | ||
| DistributionInfo dist = olapTable.getDefaultDistributionInfo(); | ||
| inferredBucketNum = Math.max(inferredBucketNum, dist.getBucketNum()); |
There was a problem hiding this comment.
The base table bucket number may be too larger for MV?
If the data can aggregated to 10x times, the bucket number in the base table is not suitable for the MV
There was a problem hiding this comment.
i know, but it's better than now
ABingHuang
previously approved these changes
Jul 10, 2023
murphyatwork
force-pushed
the
murphy_fix_show_create_mv
branch
from
94f6a05 to
83d45c4
Compare
|
Kudos, SonarCloud Quality Gate passed! |
[FE PR Coverage Check]😍 pass : 22 / 22 (100.00%) file detail
|
packy92
approved these changes
Jul 11, 2023
satanson
approved these changes
Jul 12, 2023
|
@Mergifyio backport branch-3.1 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
1. Unify the bucket number inference code to `Table::inferDistribution` 2. Not change default bucket number, so `show create table` would not display the bucket number if not specified manually (cherry picked from commit c9e9dad) # Conflicts: # test/sql/test_materialized_view/R/test_create # test/sql/test_materialized_view/R/test_show_materialized_view
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 12, 2023
1. Unify the bucket number inference code to `Table::inferDistribution` 2. Not change default bucket number, so `show create table` would not display the bucket number if not specified manually (cherry picked from commit c9e9dad) # Conflicts: # test/sql/test_materialized_view/R/test_create # test/sql/test_materialized_view/R/test_show_materialized_view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #issue
Table::inferDistributionshow create tablewould not display the bucket number if not specified manuallyWhat type of PR is this:
Checklist:
Bugfix cherry-pick branch check: