Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] ReplicationNum has not been reset when doing restore (#26423) #26471

Merged
merged 1 commit into from
Jul 5, 2023
Merged

[BugFix] ReplicationNum has not been reset when doing restore (#26423) #26471

merged 1 commit into from
Jul 5, 2023

Conversation

srlch
Copy link
Contributor

@srlch srlch commented Jul 4, 2023 •
edited
Loading

Problem:
If we restore a table which has not been created currently. The ReplicationNum of the table will be reset and will be inconsistent with the ReplicationNum with partition info

Solution:
reset the ReplicationNum

Fixes #26423

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.1
    • 3.0
    • 2.5
    • 2.4

@srlch
[BugFix] ReplicationNum has not been set when doing restore (StarRock…
2fa0f7a 
…s#26423)

Problem:
If we restore a table which has not been created currently. The
ReplicationNum of the table will be the same as the table which make the snapshot.

Solution:
reset the ReplicationNum

Signed-off-by: srlch <linzichao@starrocks.com>
@mergify mergify bot assigned srlch Jul 4, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@srlch srlch changed the title [BugFix] ReplicationNum has not been set when doing restore (#26423) [BugFix] ReplicationNum has not been reset when doing restore (#26423) Jul 4, 2023
@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😞 fail : 0 / 1 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/OlapTable.java 0 1 00.00% [676]

@Astralidea Astralidea merged commit bb26dfe into StarRocks:main Jul 5, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Jul 5, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@mergify
Copy link
Contributor

mergify bot commented Jul 5, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@github-actions github-actions bot removed the 3.0 label Jul 5, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Jul 5, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.4

@mergify
Copy link
Contributor

mergify bot commented Jul 5, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@github-actions github-actions bot removed the 2.4 label Jul 5, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 5, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Jul 5, 2023 •
edited
Loading

backport branch-2.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 5, 2023
@srlch @mergify
[BugFix] ReplicationNum has not been reset when doing restore (#26423) (
32e9aee 
#26471)

Problem:
If we restore a table which has not been created currently. The
ReplicationNum of the table will be the same as the table which make the
snapshot.

Solution:
reset the ReplicationNum

Signed-off-by: srlch <linzichao@starrocks.com>
(cherry picked from commit bb26dfe)
@mergify mergify bot mentioned this pull request Jul 5, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jul 5, 2023
@srlch @mergify
[BugFix] ReplicationNum has not been reset when doing restore (#26423) (
c699efd 
#26471)

Problem:
If we restore a table which has not been created currently. The
ReplicationNum of the table will be the same as the table which make the
snapshot.

Solution:
reset the ReplicationNum

Signed-off-by: srlch <linzichao@starrocks.com>
(cherry picked from commit bb26dfe)
mergify bot pushed a commit that referenced this pull request Jul 5, 2023
@srlch @mergify
[BugFix] ReplicationNum has not been reset when doing restore (#26423) (
fa839e4 
#26471)

Problem:
If we restore a table which has not been created currently. The
ReplicationNum of the table will be the same as the table which make the
snapshot.

Solution:
reset the ReplicationNum

Signed-off-by: srlch <linzichao@starrocks.com>
(cherry picked from commit bb26dfe)
This was referenced Jul 5, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jul 5, 2023
@srlch @mergify
[BugFix] ReplicationNum has not been reset when doing restore (#26423) (
85b8fc0 
#26471)

Problem:
If we restore a table which has not been created currently. The
ReplicationNum of the table will be the same as the table which make the
snapshot.

Solution:
reset the ReplicationNum

Signed-off-by: srlch <linzichao@starrocks.com>
(cherry picked from commit bb26dfe)
@mergify mergify bot mentioned this pull request Jul 5, 2023
Merged
wanpengfei-git pushed a commit that referenced this pull request Jul 5, 2023
@srlch @wanpengfei-git
[BugFix] ReplicationNum has not been reset when doing restore (#26423) (
f9c9601 
#26471)

Problem:
If we restore a table which has not been created currently. The
ReplicationNum of the table will be the same as the table which make the
snapshot.

Solution:
reset the ReplicationNum

Signed-off-by: srlch <linzichao@starrocks.com>
(cherry picked from commit bb26dfe)
wanpengfei-git pushed a commit that referenced this pull request Jul 5, 2023
@srlch @wanpengfei-git
[BugFix] ReplicationNum has not been reset when doing restore (#26423) (
165d6c1 
#26471)

Problem:
If we restore a table which has not been created currently. The
ReplicationNum of the table will be the same as the table which make the
snapshot.

Solution:
reset the ReplicationNum

Signed-off-by: srlch <linzichao@starrocks.com>
(cherry picked from commit bb26dfe)
wanpengfei-git pushed a commit that referenced this pull request Jul 5, 2023
@srlch @wanpengfei-git
[BugFix] ReplicationNum has not been reset when doing restore (#26423) (
4e4875d 
#26471)

Problem:
If we restore a table which has not been created currently. The
ReplicationNum of the table will be the same as the table which make the
snapshot.

Solution:
reset the ReplicationNum

Signed-off-by: srlch <linzichao@starrocks.com>
(cherry picked from commit bb26dfe)
wanpengfei-git pushed a commit that referenced this pull request Jul 5, 2023
@srlch @wanpengfei-git
[BugFix] ReplicationNum has not been reset when doing restore (#26423) (
21dbf3d 
#26471)

Problem:
If we restore a table which has not been created currently. The
ReplicationNum of the table will be the same as the table which make the
snapshot.

Solution:
reset the ReplicationNum

Signed-off-by: srlch <linzichao@starrocks.com>
(cherry picked from commit bb26dfe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjun-git gengjun-git gengjun-git approved these changes

@trueeyu trueeyu trueeyu approved these changes

Assignees

@srlch srlch

Labels
2.4 2.5 3.0 3.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BugFix] ReplicationNum has not been set when doing restore
5 participants
@srlch @wanpengfei-git @trueeyu @gengjun-git @Astralidea