Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Remove all methods of Cluster #25185

Merged
merged 1 commit into from
Jun 14, 2023
Merged

[Refactor] Remove all methods of Cluster #25185

merged 1 commit into from
Jun 14, 2023

Conversation

imay
Copy link
Contributor

@imay imay commented Jun 13, 2023

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.1
    • 3.0
    • 2.5
    • 2.4

@imay
[Refactor] Remove all methods of Cluster
c3940d0 
Signed-off-by: imay <buaa.zhaoc@gmail.com>
@mergify mergify bot assigned imay Jun 13, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 20 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@nshangyiming nshangyiming enabled auto-merge (squash) June 13, 2023 13:23
@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😞 fail : 15 / 33 (45.45%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/cluster/Cluster.java 5 11 45.45% [102, 104, 110, 116, 122, 130]
🔵 com/starrocks/system/SystemInfoService.java 10 22 45.45% [294, 295, 297, 298, 299, 926, 927, 928, 929, 931, 932, 950]

@imay imay disabled auto-merge June 14, 2023 02:24
@imay imay merged commit 5b295e2 into StarRocks:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshangyiming nshangyiming nshangyiming approved these changes

Assignees

@imay imay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imay @wanpengfei-git @nshangyiming