[Refactor] Move the STARROCKS_VERSION and STARROCKS_COMMIT_HASH to the build.sh #24215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e build.sh Currently, the two variable are defined in the build-support/gen_build_version.py. It's hard to debug and search. The pull request move the logic to the build.sh. The definition logic of STARROCKS_VERSION is as the following. 1. If the user set the STARROCKS_VERSION, use the user's definition. 2. If the current commit has a tag, use that tag 3. If no tag is available, use the branch name 4. If not a branch, use the commit-hash
kevincai
approved these changes
May 26, 2023
imay
approved these changes
May 26, 2023
|
@mergify backport branch-3.0 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 2, 2023
…e build.sh (#24215) Currently, the two variables are defined in the `build-support/gen_build_version.py`. It's hard to debug and search. The pull request move the logic to the build.sh. The definition logic of STARROCKS_VERSION is as the following. 1. If the user set the STARROCKS_VERSION, use the user's definition. 2. If the current commit is a tag, use the tag name. 3. If no tag is available, use the branch name 4. If not a branch, use the commit-hash (cherry picked from commit 5af915f) # Conflicts: # build-support/gen_build_version.py # build.sh
|
@mergify backport branch-2.5 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 2, 2023
…e build.sh (#24215) Currently, the two variables are defined in the `build-support/gen_build_version.py`. It's hard to debug and search. The pull request move the logic to the build.sh. The definition logic of STARROCKS_VERSION is as the following. 1. If the user set the STARROCKS_VERSION, use the user's definition. 2. If the current commit is a tag, use the tag name. 3. If no tag is available, use the branch name 4. If not a branch, use the commit-hash (cherry picked from commit 5af915f) # Conflicts: # build-support/gen_build_version.py # build.sh
abc982627271
pushed a commit
to abc982627271/starrocks
that referenced
this pull request
Jun 5, 2023
…e build.sh (StarRocks#24215) Currently, the two variables are defined in the `build-support/gen_build_version.py`. It's hard to debug and search. The pull request move the logic to the build.sh. The definition logic of STARROCKS_VERSION is as the following. 1. If the user set the STARROCKS_VERSION, use the user's definition. 2. If the current commit is a tag, use the tag name. 3. If no tag is available, use the branch name 4. If not a branch, use the commit-hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the two variables are defined in the
build-support/gen_build_version.py. It's hard to debug and search. The pull request move the logic to the build.sh. The definition logic of STARROCKS_VERSION is as the following.What type of PR is this:
Checklist:
Bugfix cherry-pick branch check: