Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] upgrade roaring bitmap lib to v1.1.3 #23502

Merged
merged 1 commit into from
May 17, 2023
Merged

[Enhancement] upgrade roaring bitmap lib to v1.1.3 #23502

merged 1 commit into from
May 17, 2023

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented May 16, 2023 •
edited by chaoyli
Loading

Problem Summary:

The related pr of RoaringBitmap: https://github.com/RoaringBitmap/CRoaring/pull/246/files
This bug will cause queries based on BitmapIndex to return wrong data, so upgrade roaring bitmap lib

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 3.0
    • 2.5
    • 2.4
    • 2.3

@trueeyu trueeyu force-pushed the upgrade_roaring_bitmap branch 2 times, most recently from a409c09 to 4f47c6a Compare May 17, 2023 01:32
@trueeyu trueeyu changed the title [WIP] [Enhancement] upgrade roaring bitmap lib to v1.1.3 [Enhancement] upgrade roaring bitmap lib to v1.1.3 May 17, 2023
@trueeyu trueeyu force-pushed the upgrade_roaring_bitmap branch from 4f47c6a to d3caa9c Compare May 17, 2023 01:33
@trueeyu
comment
487c0b5 
Signed-off-by: trueeyu <lxhhust350@qq.com>
@trueeyu trueeyu force-pushed the upgrade_roaring_bitmap branch from d3caa9c to 487c0b5 Compare May 17, 2023 01:41
@trueeyu trueeyu merged commit e6ee2f3 into StarRocks:main May 17, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label May 17, 2023
@mergify
Copy link
Contributor

mergify bot commented May 17, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify mergify bot mentioned this pull request May 17, 2023
Closed
mergify bot pushed a commit that referenced this pull request May 17, 2023
@trueeyu @mergify
[Enhancement] upgrade roaring bitmap lib to v1.1.3 (#23502)
015a260 
The related pr of RoaringBitmap:
https://github.com/RoaringBitmap/CRoaring/pull/246/files
This bug will cause queries based on BitmapIndex to return wrong data,
so upgrade roaring bitmap lib

Signed-off-by: trueeyu <lxhhust350@qq.com>
(cherry picked from commit e6ee2f3)

# Conflicts:
#	be/src/storage/rowset/segment_iterator.cpp
#	be/test/types/bitmap_value_test.cpp
trueeyu added a commit to trueeyu/starrocks that referenced this pull request May 17, 2023
@trueeyu
[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks#23502)
7886b82 
The related pr of RoaringBitmap:
https://github.com/RoaringBitmap/CRoaring/pull/246/files
This bug will cause queries based on BitmapIndex to return wrong data,
so upgrade roaring bitmap lib

Signed-off-by: trueeyu <lxhhust350@qq.com>
andyziye pushed a commit to trueeyu/starrocks that referenced this pull request May 17, 2023
@trueeyu @andyziye
[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks#23502)
8e3ebf5 
The related pr of RoaringBitmap:
https://github.com/RoaringBitmap/CRoaring/pull/246/files
This bug will cause queries based on BitmapIndex to return wrong data,
so upgrade roaring bitmap lib

Signed-off-by: trueeyu <lxhhust350@qq.com>
andyziye pushed a commit to trueeyu/starrocks that referenced this pull request May 17, 2023
@trueeyu @andyziye
[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks#23502)
d9de16d 
The related pr of RoaringBitmap:
https://github.com/RoaringBitmap/CRoaring/pull/246/files
This bug will cause queries based on BitmapIndex to return wrong data,
so upgrade roaring bitmap lib

Signed-off-by: trueeyu <lxhhust350@qq.com>
silverbullet233 added a commit to silverbullet233/starrocks that referenced this pull request May 17, 2023
@silverbullet233
Revert "[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks…
0569d90 
…#23502)"

This reverts commit e6ee2f3.
silverbullet233 added a commit to silverbullet233/starrocks that referenced this pull request May 17, 2023
@silverbullet233
Revert "Revert "[Enhancement] upgrade roaring bitmap lib to v1.1.3 (S…
3d2fd63 
…tarRocks#23502)""

This reverts commit 0569d90.
silverbullet233 added a commit to silverbullet233/starrocks that referenced this pull request May 17, 2023
@silverbullet233
Revert "[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks…
f62541d 
…#23502)"

This reverts commit e6ee2f3.

Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>
silverbullet233 added a commit to silverbullet233/starrocks that referenced this pull request May 17, 2023
@silverbullet233
Revert "Revert "[Enhancement] upgrade roaring bitmap lib to v1.1.3 (S…
1b714f7 
…tarRocks#23502)""

This reverts commit 0569d90.

Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>
trueeyu added a commit that referenced this pull request May 18, 2023
@trueeyu
[Enhancement] upgrade roaring bitmap lib to v1.1.3 (#23502) (#23570)
26c387c 
The related pr of RoaringBitmap:
https://github.com/RoaringBitmap/CRoaring/pull/246/files This bug will
cause queries based on BitmapIndex to return wrong data, so upgrade
roaring bitmap lib
dirtysalt pushed a commit to dirtysalt/starrocks that referenced this pull request May 18, 2023
@trueeyu @dirtysalt
[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks#23502)
2a24966 
The related pr of RoaringBitmap:
https://github.com/RoaringBitmap/CRoaring/pull/246/files
This bug will cause queries based on BitmapIndex to return wrong data,
so upgrade roaring bitmap lib

Signed-off-by: trueeyu <lxhhust350@qq.com>
Conflicts:
	be/src/storage/rowset/bitmap_range_iterator.h
	be/src/storage/rowset/segment_iterator.cpp
	be/test/types/bitmap_value_test.cpp
silverbullet233 added a commit to silverbullet233/starrocks that referenced this pull request May 23, 2023
@silverbullet233
Revert "[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks…
a6d1d9b 
…#23502)"

This reverts commit e6ee2f3.
silverbullet233 added a commit to silverbullet233/starrocks that referenced this pull request May 23, 2023
@silverbullet233
Revert "Revert "[Enhancement] upgrade roaring bitmap lib to v1.1.3 (S…
c2dbc59 
…tarRocks#23502)""

This reverts commit a6d1d9b.
silverbullet233 added a commit to silverbullet233/starrocks that referenced this pull request May 23, 2023
@silverbullet233
Revert "[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks…
ee87e7e 
…#23502)"

This reverts commit e6ee2f3.

Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>
silverbullet233 added a commit to silverbullet233/starrocks that referenced this pull request May 23, 2023
@silverbullet233
Revert "Revert "[Enhancement] upgrade roaring bitmap lib to v1.1.3 (S…
15180b2 
…tarRocks#23502)""

This reverts commit a6d1d9b.

Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>
silverbullet233 added a commit to silverbullet233/starrocks that referenced this pull request May 23, 2023
@silverbullet233
Revert "[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks…
2174ec8 
…#23502)"

This reverts commit e6ee2f3.

Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>
silverbullet233 added a commit to silverbullet233/starrocks that referenced this pull request May 23, 2023
@silverbullet233
Revert "Revert "[Enhancement] upgrade roaring bitmap lib to v1.1.3 (S…
60bd60f 
…tarRocks#23502)""

This reverts commit a6d1d9b.

Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>
Moonm3n pushed a commit to Moonm3n/starrocks that referenced this pull request May 23, 2023
@trueeyu @Moonm3n
[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks#23502)
65dcc53 
The related pr of RoaringBitmap:
https://github.com/RoaringBitmap/CRoaring/pull/246/files
This bug will cause queries based on BitmapIndex to return wrong data,
so upgrade roaring bitmap lib

Signed-off-by: trueeyu <lxhhust350@qq.com>
Signed-off-by: Moonm3n <saxonzhan@gmail.com>
numbernumberone pushed a commit to numbernumberone/starrocks that referenced this pull request May 31, 2023
@trueeyu
[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks#23502)
dc5e15a 
The related pr of RoaringBitmap:
https://github.com/RoaringBitmap/CRoaring/pull/246/files
This bug will cause queries based on BitmapIndex to return wrong data,
so upgrade roaring bitmap lib

Signed-off-by: trueeyu <lxhhust350@qq.com>
numbernumberone pushed a commit to numbernumberone/starrocks that referenced this pull request May 31, 2023
@trueeyu
[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks#23502)
00f15f6 
The related pr of RoaringBitmap:
https://github.com/RoaringBitmap/CRoaring/pull/246/files
This bug will cause queries based on BitmapIndex to return wrong data,
so upgrade roaring bitmap lib

Signed-off-by: trueeyu <lxhhust350@qq.com>
luohaha added a commit to luohaha/starrocks that referenced this pull request Jun 1, 2023
@luohaha
Revert "[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks…
cc46f31 
…#23502)"

This reverts commit e6ee2f3.
abc982627271 pushed a commit to abc982627271/starrocks that referenced this pull request Jun 5, 2023
@trueeyu @abc982627271
[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks#23502)
81d9ea8 
The related pr of RoaringBitmap:
https://github.com/RoaringBitmap/CRoaring/pull/246/files
This bug will cause queries based on BitmapIndex to return wrong data,
so upgrade roaring bitmap lib

Signed-off-by: trueeyu <lxhhust350@qq.com>
kangkaisen added a commit to kangkaisen/starrocks that referenced this pull request Jun 6, 2023
@kangkaisen
Revert "[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks…
ed48970 
…#23502)"

This reverts commit e6ee2f3.
luohaha added a commit to luohaha/starrocks that referenced this pull request Jun 7, 2023
@luohaha
Revert "[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks…
d1c1f75 
…#23502)"

This reverts commit e6ee2f3.
luohaha added a commit to luohaha/starrocks that referenced this pull request Jun 16, 2023
@luohaha
Revert "[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks…
c83da58 
…#23502)"

This reverts commit e6ee2f3.
luohaha added a commit to luohaha/starrocks that referenced this pull request Jun 21, 2023
@luohaha
Revert "[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks…
cb5f03c 
…#23502)"

This reverts commit e6ee2f3.
luohaha added a commit to luohaha/starrocks that referenced this pull request Jun 24, 2023
@luohaha
Revert "[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks…
54776fb 
…#23502)"

This reverts commit e6ee2f3.
luohaha added a commit to luohaha/starrocks that referenced this pull request Jul 8, 2023
@luohaha
Revert "[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks…
9606636 
…#23502)"

This reverts commit e6ee2f3.
luohaha added a commit to luohaha/starrocks that referenced this pull request Jul 19, 2023
@luohaha
Revert "[Enhancement] upgrade roaring bitmap lib to v1.1.3 (StarRocks…
675544a 
…#23502)"

This reverts commit e6ee2f3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imay imay imay approved these changes

@chaoyli chaoyli chaoyli approved these changes

Assignees

@trueeyu trueeyu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trueeyu @wanpengfei-git @imay @chaoyli