[Feature] Add width_bucket function #22787
Open
+443
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
liuyehcf
reviewed
May 23, 2023
docs/sql-reference/sql-functions/math-functions/width_bucket.md
Outdated
Show resolved
Hide resolved
|
run all |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
liuyehcf
force-pushed
the
feature/add_width_bucket
branch
from
95088ac to
c90ab51
Compare
liuyehcf
previously approved these changes
Jul 12, 2023
|
Please fix the problems based on the ci reports. At least those marked required. |
TBCCC
force-pushed
the
feature/add_width_bucket
branch
from
c90ab51 to
a4234b5
Compare
[FE PR Coverage Check]😍 pass : 0 / 0 (0%) |
done |
liuyehcf
previously approved these changes
Aug 3, 2023
|
LGTM |
silverbullet233
previously approved these changes
Aug 3, 2023
fzhedu
reviewed
Aug 3, 2023
gensrc/script/functions.py
Outdated
Comment on lines
189
to
199
| [10324, "width_bucket", "BIGINT", ["TINYINT", "TINYINT", "TINYINT", "BIGINT"], "MathFunctions::width_bucket<TYPE_TINYINT>"], | ||
| [103241, "width_bucket", "BIGINT", ["SMALLINT", "SMALLINT", "SMALLINT", "BIGINT"], "MathFunctions::width_bucket<TYPE_SMALLINT>"], | ||
| [103242, "width_bucket", "BIGINT", ["INT", "INT", "INT", "BIGINT"], "MathFunctions::width_bucket<TYPE_INT>"], | ||
| [103243, "width_bucket", "BIGINT", ["BIGINT", "BIGINT", "BIGINT", "BIGINT"], "MathFunctions::width_bucket<TYPE_BIGINT>"], | ||
| [103244, "width_bucket", "BIGINT", ["FLOAT", "FLOAT", "FLOAT", "BIGINT"], "MathFunctions::width_bucket<TYPE_FLOAT>"], | ||
| [103245, "width_bucket", "BIGINT", ["DOUBLE", "DOUBLE", "DOUBLE", "BIGINT"], "MathFunctions::width_bucket<TYPE_DOUBLE>"], | ||
|
|
fzhedu
reviewed
Aug 3, 2023
Comment on lines
+2
to
+13
| select width_bucket(5.35, 0.024, 10.06, 5); | ||
| -- result: | ||
| 3 | ||
| -- !result | ||
| select width_bucket(0, 0.024, 10.06, 5); | ||
| -- result: | ||
| 0 | ||
| -- !result | ||
| select width_bucket(11, 0.024, 10.06, 5); | ||
| -- result: | ||
| 6 | ||
| -- !result |
There was a problem hiding this comment.
please some cases for null input
fzhedu
reviewed
Aug 3, 2023
be/src/exprs/math_functions.h
Outdated
Comment on lines
522
to
524
| auto range_size = max_value - min_value; | ||
| auto dist_from_min = input_value - min_value; | ||
| int64_t ret = dist_from_min / (range_size / bucket_num); |
There was a problem hiding this comment.
shoud / return double ? otherwise range_size/bucket_num would return 0.
what if max_value <= min_value?
TBCCC
force-pushed
the
feature/add_width_bucket
branch
from
a4234b5 to
4250da8
Compare
TBCCC
force-pushed
the
feature/add_width_bucket
branch
3 times, most recently
from
8154ca7 to
81fe5b3
Compare
|
@liuyehcf PTAL, I have fixed all issues above. And the CI failures seems not relevant to my pr. |
Signed-off-by: TBCCC <tbccc55555@outlook.com>
Signed-off-by: TBCCC <tbccc55555@outlook.com>
Signed-off-by: TBCCC <tbccc55555@outlook.com>
Signed-off-by: TBCCC <tbccc55555@outlook.com>
Signed-off-by: TBCCC <tbccc55555@outlook.com>
Signed-off-by: TBCCC <tbccc55555@outlook.com>
Signed-off-by: TBCCC <tbccc55555@outlook.com>
TBCCC
force-pushed
the
feature/add_width_bucket
branch
from
2772bbb to
83877d7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 0 / 40 (00.00%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
Which issues of this PR fixes:
Fixes #12990
Problem Summary(Required):
Checklist:
Bugfix cherry-pick branch check: