Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add a download button in the query UI #22153

Merged
merged 1 commit into from
Apr 21, 2023
Merged

[Enhancement] Add a download button in the query UI #22153

merged 1 commit into from
Apr 21, 2023

Conversation

Astralidea
Copy link
Contributor

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes :

Fixes #19406

Problem Summary(Required) :

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 3.0
    • 2.5
    • 2.4
    • 2.3

Signed-off-by: Astralidea <astralidea@163.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😞 fail : 0 / 1 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/http/action/QueryAction.java 0 1 00.00% [74]

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 41.55% and project coverage change: -0.19 ⚠️

Comparison is base (0b4a229) 60.38% compared to head (d93b685) 60.20%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #22153      +/-   ##
============================================
- Coverage     60.38%   60.20%   -0.19%     
- Complexity    30156    30214      +58     
============================================
  Files          2143     2148       +5     
  Lines        172195   173058     +863     
  Branches      25833    26080     +247     
============================================
+ Hits         103987   104194     +207     
- Misses        58776    59321     +545     
- Partials       9432     9543     +111     
Impacted Files Coverage Δ
...rc/main/java/com/starrocks/alter/AlterHandler.java 50.00% <ø> (ø)
.../java/com/starrocks/alter/SchemaChangeHandler.java 39.06% <0.00%> (-1.42%) ⬇️
.../main/java/com/starrocks/analysis/LiteralExpr.java 73.84% <ø> (ø)
.../main/java/com/starrocks/backup/BackupHandler.java 47.53% <ø> (ø)
...src/main/java/com/starrocks/backup/RestoreJob.java 14.61% <0.00%> (-0.13%) ⬇️
.../java/com/starrocks/catalog/CatalogRecycleBin.java 53.26% <ø> (ø)
...ain/java/com/starrocks/catalog/DomainResolver.java 25.92% <ø> (ø)
.../java/com/starrocks/catalog/ExternalOlapTable.java 0.00% <0.00%> (ø)
.../main/java/com/starrocks/catalog/IcebergTable.java 37.19% <0.00%> (-0.63%) ⬇️
...ore/src/main/java/com/starrocks/catalog/Table.java 69.36% <0.00%> (-0.30%) ⬇️
... and 126 more

... and 59 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Astralidea Astralidea enabled auto-merge (squash) April 21, 2023 10:48
@Astralidea Astralidea merged commit ef4872c into StarRocks:main Apr 21, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 3.0 label Apr 21, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2023

backport branch-3.0

✅ Backports have been created

@github-actions github-actions bot removed the 2.5 label Apr 21, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2023

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 21, 2023
Signed-off-by: Astralidea <astralidea@163.com>
(cherry picked from commit ef4872c)
mergify bot pushed a commit that referenced this pull request Apr 21, 2023
Signed-off-by: Astralidea <astralidea@163.com>
(cherry picked from commit ef4872c)
wanpengfei-git pushed a commit that referenced this pull request Apr 23, 2023
Signed-off-by: Astralidea <astralidea@163.com>
(cherry picked from commit ef4872c)
abc982627271 pushed a commit to abc982627271/starrocks that referenced this pull request Apr 24, 2023
Signed-off-by: Astralidea <astralidea@163.com>
numbernumberone pushed a commit to numbernumberone/starrocks that referenced this pull request May 31, 2023
Signed-off-by: Astralidea <astralidea@163.com>
abc982627271 pushed a commit to abc982627271/starrocks that referenced this pull request Jun 5, 2023
Signed-off-by: Astralidea <astralidea@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a button in the query UI to send logs to support
4 participants