Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix olap table shallowCopy bug #21905

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

kangkaisen
Copy link
Collaborator

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes :

Fixes # #21904

Problem Summary(Required) :

we don't copy the index meta for the partition.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 3.0
    • 2.5
    • 2.4
    • 2.3

Signed-off-by: kangkaisen <kangkaisen@apache.org>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 22 / 22 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/Partition.java 13 13 100.00% []
🔵 com/starrocks/catalog/OlapTable.java 9 9 100.00% []

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (b496b19) 60.30% compared to head (d1e8bc9) 60.30%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #21905      +/-   ##
============================================
- Coverage     60.30%   60.30%   -0.01%     
+ Complexity    30068    30064       -4     
============================================
  Files          2144     2144              
  Lines        171885   171911      +26     
  Branches      25811    25817       +6     
============================================
+ Hits         103663   103668       +5     
- Misses        58783    58811      +28     
+ Partials       9439     9432       -7     
Impacted Files Coverage Δ
...src/main/java/com/starrocks/catalog/OlapTable.java 73.64% <100.00%> (+0.15%) ⬆️
...src/main/java/com/starrocks/catalog/Partition.java 72.96% <100.00%> (+1.59%) ⬆️

... and 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kangkaisen
Copy link
Collaborator Author

For 1892 partitions, the copy time is 5ms.

@kangkaisen kangkaisen merged commit 750a54f into StarRocks:main Apr 19, 2023
@kangkaisen kangkaisen deleted the copy branch April 19, 2023 09:17
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@mergify
Copy link
Contributor

mergify bot commented Apr 19, 2023

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 19, 2023
Signed-off-by: kangkaisen <kangkaisen@apache.org>
(cherry picked from commit 750a54f)
kangkaisen added a commit that referenced this pull request Apr 20, 2023
Signed-off-by: kangkaisen <kangkaisen@apache.org>
(cherry picked from commit 750a54f)

Co-authored-by: kangkaisen <kangkaisen@apache.org>
kobebryantlin0 pushed a commit to kobebryantlin0/starrocks that referenced this pull request Apr 21, 2023
Signed-off-by: kangkaisen <kangkaisen@apache.org>
numbernumberone pushed a commit to numbernumberone/starrocks that referenced this pull request May 31, 2023
Signed-off-by: kangkaisen <kangkaisen@apache.org>
abc982627271 pushed a commit to abc982627271/starrocks that referenced this pull request Jun 5, 2023
Signed-off-by: kangkaisen <kangkaisen@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants