Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Make the number of thread that async lazy refresh the remote file cache configurable. #21676

Merged

Conversation

stephen-shelby
Copy link
Contributor

@stephen-shelby stephen-shelby commented Apr 14, 2023

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes :

Fixes #

Problem Summary(Required) :

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 3.0
    • 2.5
    • 2.4
    • 2.3

…emote file cache configurable.

Signed-off-by: stephen <stephen5217@163.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@05b45b5). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21676   +/-   ##
=======================================
  Coverage        ?   60.33%           
  Complexity      ?    30087           
=======================================
  Files           ?     2142           
  Lines           ?   171792           
  Branches        ?    25763           
=======================================
  Hits            ?   103644           
  Misses          ?    58754           
  Partials        ?     9394           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the 2.5 label Apr 17, 2023
@stephen-shelby stephen-shelby merged commit cb8ff23 into StarRocks:main Apr 17, 2023
@github-actions github-actions bot added the 3.0 label Apr 17, 2023
@stephen-shelby stephen-shelby deleted the adjust_refresh_hms_thread_num branch April 17, 2023 03:18
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Apr 17, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 17, 2023

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 17, 2023
…emote file cache configurable. (#21676)

Signed-off-by: stephen <stephen5217@163.com>
(cherry picked from commit cb8ff23)
@stephen-shelby
Copy link
Contributor Author

@Mergifyio backport branch-3.0

@mergify
Copy link
Contributor

mergify bot commented Apr 17, 2023

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 17, 2023
…emote file cache configurable. (#21676)

Signed-off-by: stephen <stephen5217@163.com>
(cherry picked from commit cb8ff23)
wanpengfei-git pushed a commit that referenced this pull request Apr 17, 2023
…emote file cache configurable. (#21676)

Signed-off-by: stephen <stephen5217@163.com>
(cherry picked from commit cb8ff23)
wanpengfei-git pushed a commit that referenced this pull request Apr 17, 2023
…emote file cache configurable. (#21676)

Signed-off-by: stephen <stephen5217@163.com>
(cherry picked from commit cb8ff23)
numbernumberone pushed a commit to numbernumberone/starrocks that referenced this pull request May 31, 2023
…emote file cache configurable. (StarRocks#21676)

Signed-off-by: stephen <stephen5217@163.com>
abc982627271 pushed a commit to abc982627271/starrocks that referenced this pull request Jun 5, 2023
…emote file cache configurable. (StarRocks#21676)

Signed-off-by: stephen <stephen5217@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants