Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Support for alternation of confluent schema registry addr #21241

Merged
merged 1 commit into from
Apr 12, 2023
Merged

[Enhancement] Support for alternation of confluent schema registry addr #21241

merged 1 commit into from
Apr 12, 2023

Conversation

zaorangyang
Copy link
Contributor

@zaorangyang zaorangyang commented Apr 10, 2023 •
edited by chaoyli
Loading

What type of PR is this：

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes ：

Fixes #

Problem Summary(Required) ：

This PR allows you to change the confluent schema registry address for a routine load. If you want to change this property, you can use this SQL:

ALTER ROUTINE LOAD FOR db1.label1
FROM Kafka
(
   "confluent.schema.registry.url"="https:key:password@registryserverAddr"
);

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 3.0
    • 2.5
    • 2.4
    • 2.3

@zaorangyang
[Enhancement] Support for alternation of confluent schema registry addr
29b0ad6 
Signed-off-by: Zaorang Yang <zaorangy@gmail.com>
@github-actions github-actions bot added the 3.0 label Apr 10, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@chaoyli chaoyli merged commit daa7b03 into StarRocks:main Apr 12, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@mergify
Copy link
Contributor

mergify bot commented Apr 12, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 12, 2023
@zaorangyang @mergify
[Enhancement] Support for alternation of confluent schema registry ad…
8bd65ba 
…dr (#21241)

This PR allows you to change the confluent schema registry address for a routine load. If you want to change this property, you can use this SQL:

ALTER ROUTINE LOAD FOR db1.label1
FROM Kafka
(
   "confluent.schema.registry.url"="https:key:password@registryserverAddr"
);

(cherry picked from commit daa7b03)
@mergify mergify bot mentioned this pull request Apr 12, 2023
Merged
wanpengfei-git pushed a commit that referenced this pull request Apr 12, 2023
@zaorangyang @wanpengfei-git
[Enhancement] Support for alternation of confluent schema registry ad…
08fda46 
…dr (#21241)

This PR allows you to change the confluent schema registry address for a routine load. If you want to change this property, you can use this SQL:

ALTER ROUTINE LOAD FOR db1.label1
FROM Kafka
(
   "confluent.schema.registry.url"="https:key:password@registryserverAddr"
);

(cherry picked from commit daa7b03)
@chaoyli chaoyli mentioned this pull request Apr 13, 2023
Merged
16 tasks
imay pushed a commit that referenced this pull request Apr 13, 2023
@zaorangyang
[BugFix] Fix an issue of modify confluent schema registry (#21552)
c9160c9 
PR #21241 supports modifying the schema registry address, but when modifying other parameters, FE fails to pass schema registry address parameters to BE, causing the task aborted. This PR fixes the problem.

Signed-off-by: Zaorang Yang <zaorangy@gmail.com>
mergify bot pushed a commit that referenced this pull request Apr 13, 2023
@zaorangyang @mergify
[BugFix] Fix an issue of modify confluent schema registry (#21552)
9ab31d0 
PR #21241 supports modifying the schema registry address, but when modifying other parameters, FE fails to pass schema registry address parameters to BE, causing the task aborted. This PR fixes the problem.

Signed-off-by: Zaorang Yang <zaorangy@gmail.com>
(cherry picked from commit c9160c9)
wanpengfei-git pushed a commit that referenced this pull request Apr 13, 2023
@zaorangyang @wanpengfei-git
[BugFix] Fix an issue of modify confluent schema registry (#21552)
7061ce3 
PR #21241 supports modifying the schema registry address, but when modifying other parameters, FE fails to pass schema registry address parameters to BE, causing the task aborted. This PR fixes the problem.

Signed-off-by: Zaorang Yang <zaorangy@gmail.com>
(cherry picked from commit c9160c9)
numbernumberone pushed a commit to numbernumberone/starrocks that referenced this pull request May 31, 2023
@zaorangyang
[Enhancement] Support for alternation of confluent schema registry ad…
53c2ae2 
…dr (StarRocks#21241)

This PR allows you to change the confluent schema registry address for a routine load. If you want to change this property, you can use this SQL:

ALTER ROUTINE LOAD FOR db1.label1
FROM Kafka
(
   "confluent.schema.registry.url"="https:key:password@registryserverAddr"
);
numbernumberone pushed a commit to numbernumberone/starrocks that referenced this pull request May 31, 2023
@zaorangyang
[BugFix] Fix an issue of modify confluent schema registry (StarRocks#…
7c0b3a7 
…21552)

PR StarRocks#21241 supports modifying the schema registry address, but when modifying other parameters, FE fails to pass schema registry address parameters to BE, causing the task aborted. This PR fixes the problem.

Signed-off-by: Zaorang Yang <zaorangy@gmail.com>
abc982627271 pushed a commit to abc982627271/starrocks that referenced this pull request Jun 5, 2023
@zaorangyang @abc982627271
[Enhancement] Support for alternation of confluent schema registry ad…
faff3f1 
…dr (StarRocks#21241)

This PR allows you to change the confluent schema registry address for a routine load. If you want to change this property, you can use this SQL:

ALTER ROUTINE LOAD FOR db1.label1
FROM Kafka
(
   "confluent.schema.registry.url"="https:key:password@registryserverAddr"
);
abc982627271 pushed a commit to abc982627271/starrocks that referenced this pull request Jun 5, 2023
@zaorangyang @abc982627271
[BugFix] Fix an issue of modify confluent schema registry (StarRocks#…
67d0de4 
…21552)

PR StarRocks#21241 supports modifying the schema registry address, but when modifying other parameters, FE fails to pass schema registry address parameters to BE, causing the task aborted. This PR fixes the problem.

Signed-off-by: Zaorang Yang <zaorangy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meegoo meegoo meegoo approved these changes

@rickif rickif rickif approved these changes

@chaoyli chaoyli chaoyli approved these changes

Assignees

@zaorangyang zaorangyang

Labels
3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zaorangyang @wanpengfei-git @meegoo @rickif @chaoyli