Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] only use compute node to create cloudnative table #21092

Merged
merged 12 commits into from
Apr 12, 2023
Merged

[Refactor] only use compute node to create cloudnative table #21092

merged 12 commits into from
Apr 12, 2023

Conversation

abc982627271
Copy link
Contributor

@abc982627271 abc982627271 commented Apr 6, 2023 •
edited
Loading

What type of PR is this：

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes ：

Fixes #

Problem Summary(Required) ：

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 3.0
    • 2.5
    • 2.4
    • 2.3

@abc982627271 abc982627271 changed the title [Refactor] only use compute node to create tables [Refactor] only use compute node to create lake table Apr 6, 2023
@abc982627271 abc982627271 force-pushed the manage_cn_under_warehouse branch from b9899b4 to 74662cf Compare April 6, 2023 12:23
@abc982627271 abc982627271 changed the title [Refactor] only use compute node to create lake table [Refactor] only use compute node to create cloudnative table Apr 7, 2023
@sduzh sduzh requested review from wyb and sduzh April 7, 2023 06:46
sduzh
sduzh reviewed Apr 10, 2023
View reviewed changes
be/src/agent/agent_task.cpp Outdated Show resolved Hide resolved
@abc982627271 abc982627271 force-pushed the manage_cn_under_warehouse branch 2 times, most recently from 827ed1d to 8cfe98c Compare April 11, 2023 07:42
sduzh
sduzh previously approved these changes Apr 11, 2023
View reviewed changes
wyb
wyb previously approved these changes Apr 12, 2023
View reviewed changes
@abc982627271
enhance compute node
053539d 
Signed-off-by: abc982627271 <liuxuefen@starrocks.com>
@abc982627271
update codes
4ef42eb 
Signed-off-by: abc982627271 <liuxuefen@starrocks.com>
@abc982627271
modify create cloudnative table
7129d0b 
Signed-off-by: abc982627271 <liuxuefen@starrocks.com>
@abc982627271
create tables only by cn
7ab48db 
Signed-off-by: abc982627271 <liuxuefen@starrocks.com>
@abc982627271
update codes
f92162d 
Signed-off-by: abc982627271 <liuxuefen@starrocks.com>
@abc982627271
fix ut bug
ad5f7d8 
Signed-off-by: abc982627271 <liuxuefen@starrocks.com>
@abc982627271
remove debug log
4c0e04d 
Signed-off-by: abc982627271 <liuxuefen@starrocks.com>
@abc982627271
remove debug log
6c79695 
Signed-off-by: abc982627271 <liuxuefen@starrocks.com>
@abc982627271
fix bug
6fa85af 
Signed-off-by: abc982627271 <liuxuefen@starrocks.com>
@abc982627271
fix bug
4a3e8f9 
Signed-off-by: abc982627271 <liuxuefen@starrocks.com>
@abc982627271
upt
d98a96b 
Signed-off-by: abc982627271 <liuxuefen@starrocks.com>
@abc982627271
fix bug
5f024e9 
Signed-off-by: abc982627271 <liuxuefen@starrocks.com>
sduzh
sduzh previously approved these changes Apr 12, 2023
View reviewed changes
@abc982627271 abc982627271 dismissed stale reviews from sduzh and wyb via 5f024e9 April 12, 2023 06:35
@abc982627271 abc982627271 force-pushed the manage_cn_under_warehouse branch from b8c1f61 to 5f024e9 Compare April 12, 2023 06:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sduzh sduzh enabled auto-merge (squash) April 12, 2023 07:18
@sduzh sduzh merged commit 598a70a into StarRocks:main Apr 12, 2023
numbernumberone pushed a commit to numbernumberone/starrocks that referenced this pull request May 31, 2023
@abc982627271
[Refactor] only use compute node to create cloudnative table (StarRoc…
522636e 
…ks#21092)

Signed-off-by: abc982627271 <liuxuefen@starrocks.com>
abc982627271 added a commit to abc982627271/starrocks that referenced this pull request Jun 5, 2023
@abc982627271
[Refactor] only use compute node to create cloudnative table (StarRoc…
40c71d7 
…ks#21092)

Signed-off-by: abc982627271 <liuxuefen@starrocks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@sduzh sduzh sduzh approved these changes

Assignees

@abc982627271 abc982627271

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abc982627271 @wyb @sduzh