Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] use starrocks libre2 and libprotobuf for starlet #18810

Merged
merged 1 commit into from
Mar 2, 2023
Merged

[Enhancement] use starrocks libre2 and libprotobuf for starlet #18810

merged 1 commit into from
Mar 2, 2023

Conversation

kevincai
Copy link
Contributor

@kevincai kevincai commented Mar 2, 2023

  • avoid link both libraries, causes multi definition errors.

What type of PR is this：

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes ：

Fixes #

Problem Summary(Required) ：

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 3.0
    • 2.5
    • 2.4
    • 2.3

@kevincai
[Enhancement] use starrocks libre2 and libprotobuf for starlet
51bd45d 
* avoid link both libraries, causes multi definition errors.

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
@kevincai kevincai marked this pull request as draft March 2, 2023 08:36
@github-actions github-actions bot added the 3.0 label Mar 2, 2023
@kevincai kevincai marked this pull request as ready for review March 2, 2023 09:37
@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Mar 2, 2023
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

@sduzh sduzh enabled auto-merge (squash) March 2, 2023 09:49
@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 0 / 0 (0%)

@imay imay merged commit 2741473 into StarRocks:main Mar 2, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the Approved Ready to merge label Mar 2, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 2, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 2, 2023
@kevincai @mergify
[Enhancement] use starrocks libre2 and libprotobuf for starlet (#18810)
7d6884c 
(cherry picked from commit 2741473)
@mergify mergify bot mentioned this pull request Mar 2, 2023
Merged
imay pushed a commit that referenced this pull request Mar 2, 2023
@mergify
[Enhancement] use starrocks libre2 and libprotobuf for starlet (#18810)…
1a1ce6f 
… (#18824)
@kevincai kevincai deleted the fix-starlet-thirdparty-integration branch March 17, 2023 03:22
numbernumberone pushed a commit to numbernumberone/starrocks that referenced this pull request May 31, 2023
@kevincai
[Enhancement] use starrocks libre2 and libprotobuf for starlet (StarR…
d2e42c3 
…ocks#18810)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@sduzh sduzh sduzh approved these changes

Assignees
No one assigned
Labels
3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kevincai @wanpengfei-git @wyb @sduzh @imay