[BugFix] Fix array parquet def, rep level parsed error #17626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smith-Cruise
changed the title
Smith-Cruise
force-pushed
the
fix-struct-parquet
branch
3 times, most recently
from
fd2e525 to
17b4b9c
Compare
DorianZheng
requested changes
Feb 9, 2023
|
run starrocks_be_unittest |
1 similar comment
|
run starrocks_be_unittest |
Smith-Cruise
force-pushed
the
fix-struct-parquet
branch
2 times, most recently
from
3931219 to
751806b
Compare
Signed-off-by: Smith Cruise <chendingchao1@126.com>
Smith-Cruise
force-pushed
the
fix-struct-parquet
branch
from
751806b to
043d38b
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
DorianZheng
approved these changes
Feb 10, 2023
dirtysalt
approved these changes
Feb 10, 2023
|
run starrocks_admit_test |
stephen-shelby
approved these changes
Feb 10, 2023
GavinMar
reviewed
Feb 10, 2023
GavinMar
approved these changes
Feb 10, 2023
|
run starrocks_admit_test |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Kudos, SonarCloud Quality Gate passed!
|
16 tasks
16 tasks
stephen-shelby
pushed a commit
that referenced
this pull request
Feb 23, 2023
16 tasks
Jay-ju
pushed a commit
to Jay-ju/starrocks
that referenced
this pull request
Feb 27, 2023
Signed-off-by: Smith Cruise <chendingchao1@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #
Problem Summary(Required) ：
Sometimes we faced that chunk's
check_or_die()method failed in ArrayColumn, the reason is that:A chunk's size is 4096, but sometimes RepeatedColumnReader will read one more (rep & def) level, so in
def_rep_to_offsetmethod, it will calculate as 4097 rows, which means this ArrayColumn's size is 4097, not satisfied chunk's size.Checklist:
Bugfix cherry-pick branch check: